Mutagen does handle TYER+TDAT correctly. :)


On Mon, Jun 17, 2013 at 9:13 AM, Sophist-UK <notifications@github.com>wrote:

> In picard/formats/id3.py:
>
> > +
> > +    def get(self, name, default=None):
> > +        values = dict.get(self, name, None)
> > +        if not values:
> > +            return default
> > +        setting = QObject.config.setting
> > +        values = self.__id3v23_date(setting, name, values)
> > +        if setting["write_id3v23"]:
> > +            return setting["id3v23_join_with"].join(values)
> > +        else:
> > +            return MULTI_VALUED_JOINER.join(values)
> > +
> > +    def __id3v23_date(self, setting, name, values):
> > +        # id3v23 can only save dates in yyyy format (cf. id3v24 and MB who provides dates in yyyy-mm-dd format)
> > +        if (setting["write_id3v23"] and
> > +           name in ("date", "originaldate")):
>
> You are right about this - though I think we have another issue to fix.
>
> compatid3.py does indeed split the date in this way when saving and so I
> will remove date from this code. Original date can still only be year
> though.
>
> However I need to check what mutagen does with date when the file is read.
> Picard doesn't handle TYER explicitly (TDRC is the tag for date), and dates
> are read in from id3v23 files - and see if anything needs fixing.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/musicbrainz/picard/pull/107/files#r4718826>
> .
>