little change in trade controller logic