Various Puppet lint fixes

* Fixes following warnings:
    * indentation of => is not properly aligned
    * string containing only a variable
* Fixes following errors:
    * tab character found
    * two-space soft tabs not used
* Remove quotes around class in include/require statements

Change-Id: I7e17d9153d413792e32f9d7c430dfbd37852ba51
Remove unused template

Template was used by keystone::client::authtoken which is now gone.

Change-Id: I5bd7b5aa132686cc5b4b622bdc0d9763f0258a4b
Merge "Various Puppet lint fixes"
Ensure 'id' is included by keystone_tenant.instances.

 * Previously keystone_tenant was only including the 'name' field
   in the results of instances().  This patch includes the 'id'
   field to allow discovery of id from the name.

Change-Id: Ibd5b22f6b29bc0f07e5c3c1cd52a404d32ea0b89
Improve tenant_hash usage in keystone_tenant.

 * The tenant_hash used by the keystone_tenant type to keep track
   of tenants is now updated with new tenants as they are created.
 * Added 'instance' helper method that returns
   tenant_hash[resource[:name]]
 * Added spec tests for the changes.

Change-Id: I077e5012a3f2d20d3df4cc55f1150490d4b31f58
Select keystone endpoint url bases on SSL setting

When keystone is ssl enabled, (by setting ssl/enabled = TRUE in
keystone.conf) the keystone auth server is using HTTPS instead of HTTP
as the protocol. This patch generates the correct endpoint for the
keystone service calls.

In addition, if there is a defined 'admin_endpoint' in keystone.conf,
this setting will take precedence.

Change-Id: I23fe552808d8a959b0dff1c86989cf2aaa04582a
Remove Unnecessary mysql::server Dependency

Previously, the db::mysql class required mysql::server.  This is
unnecessary since the mysql::db define requires the mysql::config
class for db creattion.  Additionally, this prevents users from
using a different class such as galera::server to manage
the database.

Change-Id: Ifb0fa261f9f5921cf9fe5b309decceab608d4726
Merge "Select keystone endpoint url bases on SSL setting"
Pin  mysql to major version for fixtures

Previously, unit tests were using master for testing.

This commit changes them to use the newly created major version
branches. This allows us to backport bug fixes while we wait for
upstream to stabilize.

Change-Id: I182f79981b714f3beb4be0f137aabe960e2a151a
Update allowed_hosts conditional statement

In the origin keystone::db::mysql, if the value of $allowed_hosts
contains or equals to $host, then puppet will complain duplicate
declaration error. This patch is aim to update the allowed_hosts
conditonal statement in keystone::db::mysql.

There are two cases to pass $allowed_hosts to $real_allowed_hosts:

   - If $allowed_hosts is array,then remove $host from $allowed_hosts;
   - elsif $allowed_hosts is string and not equivalent to $host;

At last, if $real_allowed_hosts is not undef, then run
keystone::db::mysql::host_access

Fix bug 1206444

Change-Id: I8701aea9344a9151ce3d7ac8fa5792895a5aac6c
Update modulefile and fixtures to use puppetlabs/inifile

cprice404/inifile was moved to the puppetlabs namespace on the forge
and github.

Change-Id: Id8398a0db65ea3dac911230cbe31088ea1b030a3
Update modulefile and fixtures to use puppetlabs/inifile

cprice404/inifile was moved to the puppetlabs namespace on the forge
and github.

Change-Id: I9e385fcf91b08f8f5de98596d86d17f2d0bde6cb
Merge "Update modulefile and fixtures to use puppetlabs/inifile"