Right now, it's set to an empty string - I had to merge in the hash trait before I could generate the id…right now it's just a place holder for the tests. We can merge once I get the hash implemented…ran away with it a little bit and didn't consider that. I'll have to implement a Hash::exists() method on PartnershipManager

--  
Matt Frost
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)


On Friday, November 15, 2013 at 9:10 PM, Jeff Carouth wrote:

> In site/src/MentorApp/PartnershipManager.php:
> > + */ > + public function __construct(\PDO $db) > + { > + $this->db = $db; > + } > + > + /** > + * Create a partnership between a mentor and an apprentice > + * > + * @param \MentorApp\User $mentor mentoring user instance > + * @param \MentorApp\User $apprentice apprentice user instance > + * @return boolean > + */ > + public function create(User $mentor, User $apprentice) > + { > + $id = '';  
> Is the ID supposed to be actually generated? I don't think this is going to work as you expect given that id is set to the primary key of the table and afaict $id is only ever ''.
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/phpmentoring/mentor-app/pull/43/files#r7707801).
>  
>  
>