right.  the tests might be redundant, since we can't get a nil value
without something failing upstream, and the downstream code will fail also.
 The 50% issue is that the current data output is wrong -- all
probabilities are at 50%.  Robin is fixing this now.


On Mon, Apr 1, 2013 at 2:13 PM, Aaron Steele <notifications@github.com>wrote:

> In test/clj/forma/classify/logistic_test.clj:
>
> > @@ -47,3 +47,11 @@
> >    row matrix"
> >    (logistic-prob (to-double-rowmat [1 2 3])
> >                   (to-double-rowmat [0 0 0])) => (to-double-rowmat [0.5]))
> > +
> > +(tabular
> > + (fact "Test `logistic-prob-wrap`"
>
> word. i mean, we could catch it here in the spirit of failfast if we
> wanted. also i'm a leetle out of the loop on what the "all 50%" problem is
> ha, but maybe just add a little blurb about it in the docstring if it makes
> sense? otherwise lgtm. #shipit
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/reddmetrics/forma-clj/pull/353/files#r3608285>
> .
>