Understood, we can adjust and improve this overtime to follow patterns like I did for switches and nics


From: Victor Lowther [mailto:notifications@github.com]
Sent: Monday, October 21, 2013 08:34 AM Central Standard Time
To: crowbar/barclamp-crowbar <barclamp-crowbar@noreply.github.com>
Cc: Hirschfeld, Rob
Subject: Re: [barclamp-crowbar] Enable node attributes from discover data [1/2] (#741)


In crowbar_framework/db/migrate/20131018_add_node_attibs.rb:

> +#
> +
> +# Adds the attributes that we want to generically expose for Nodes
> +class AddNodeAttribs < ActiveRecord::Migration
> +
> +  def up
> +
> +    # note, these descriptions are NOT localized, we may have to consider that in the future
> +
> +    Attrib.create :name=>'asset_tag', :description=>'BIOS configured system identifier', :map=>'ohai/dmi/base_board/asset_tag'
> +    Attrib.create :name=>'serial_number', :description=>'System Serial Number', :map=>'ohai/dmi/chassis/serial_number'
> +
> +    Attrib.create :name=>'kernel', :description=>'Kermel Name', :map=>'ohai/kernel/name'
> +    Attrib.create :name=>'kernel_version', :description=>'Kernel Version', :map=>'ohai/kernel/version'
> +
> +    Attrib.create :name=>'mac_address', :description=>'MAC address', :map=>'ohai/macaddress'


I am dubious -- we usually have many, many mac addresses we care about and we should not use whatever ohai picked at random.

—
Reply to this email directly or view it on GitHub<https://github.com/crowbar/barclamp-crowbar/pull/741/files#r7093244>.