modal updates succesful
resolved attributes issue