Add the ability to trigger synced notifications in the Sync test server.

This CL also adds the option of changing the ClientCommand sent back to
the client in order to modify the commit delay for sessions. After this
change is submitted, a frontend will be added to allow easy triggering
of canned notifications.

Review URL: https://codereview.chromium.org/70933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236619 0039d316-1c4b-4281-b951-d872f2087c98
Remove bookmark api helper function overloads.

Converts the one remaining use of these functions to use the JSON
schema compiler generated classes instead.

BUG=

Review URL: https://codereview.chromium.org/79953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236620 0039d316-1c4b-4281-b951-d872f2087c98
[Sync] Support unrecoverable error uploading on non-win platforms

We now use chrome/common/dump_without_crashing.h, and only upload on canary/
dev builds.

BUG=127429

Review URL: https://codereview.chromium.org/80963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236623 0039d316-1c4b-4281-b951-d872f2087c98
Fixes broken capitalization on space after punctuation.


BUG=319938

Review URL: https://codereview.chromium.org/62873008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236624 0039d316-1c4b-4281-b951-d872f2087c98
Use SkBitmap backing instead of GDI backed platform canvas for tiles

BUG=321185

Review URL: https://codereview.chromium.org/80063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236625 0039d316-1c4b-4281-b951-d872f2087c98
Mojo JavaScript bindings should be binary compatible with C++

After this CL, the JavaScript bindings we autogenerate from
sample_service.mojom files are binary compatible with the C++ bindings. I've
also replaced the hand-written sample_service.js file with the auto-generated
version.

I've also moved the logic for assigning implicit ordinals to methods into
common code that's shared between the CPP and JS bindings generators.

BUG=317398

Review URL: https://codereview.chromium.org/81313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236626 0039d316-1c4b-4281-b951-d872f2087c98
Misc. cleanup:

* Don't inline not-normally-inlined methods in non-test code
* Shorten
* DISALLOW_COPY_AND_ASSIGN
* Overrides should be in same order as in base class
* No else after return
* Fix line wrapping, comments, indenting

I'm not bothering to clean up HorizontalPaddingButtonBorder,
NotifierGroupMenuButtonBorder, or TouchEditingMenuButtonBorder since I'll be
removing those entirely in my next patch.

BUG=none
TEST=none
R=msw@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/80103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236627 0039d316-1c4b-4281-b951-d872f2087c98
Misc. cleanup:

* Scope constants/variables as narrowly as possible
* Don't override virtual methods unnecessarily
* Minor comment improvements
* Don't inline not-normally-inlined methods in non-test code
* Use {} where required
* Eliminate leftover forward-decl in MaximizeBubbleController (oops)
* Fix indenting & wrapping

BUG=none
TEST=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/80043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236628 0039d316-1c4b-4281-b951-d872f2087c98
Adds handling of clicking on the omnibox search/go button.

BUG=304859, 311269

Review URL: https://codereview.chromium.org/78053009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236629 0039d316-1c4b-4281-b951-d872f2087c98
Update checkstyle rules.

- Change catching Exepction and Throwable as warnings.
- Allow comments for EmptyBlocks
- Allow empty methods and contructors.
- Set using finalizer as a warning.

BUG=318404
NOTRY=true

Review URL: https://codereview.chromium.org/81903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236630 0039d316-1c4b-4281-b951-d872f2087c98
a11y: Fix incorrectly echoed menu because of invisible items.

BUG=314929
TEST=AccessibilityEventRouterViewsTest.MenuIndexAndCountForInvisibleMenu

Review URL: https://codereview.chromium.org/77723011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236631 0039d316-1c4b-4281-b951-d872f2087c98
Remove spammy AudioManagerBase log.

Triggers for every linux audio stream.

BUG=none
TEST=none
TBR=tommi

Review URL: https://codereview.chromium.org/81973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236632 0039d316-1c4b-4281-b951-d872f2087c98
Two tiny comment/style fixes to RenderFrameHostFactory.

BUG=304341
TEST=None

Review URL: https://codereview.chromium.org/77243008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236633 0039d316-1c4b-4281-b951-d872f2087c98
Scroll begin and scroll end gestures ignore their ack dispositions.

BUG=302852
TEST=ImmediateInputRouterTest.GestureTypesIgnoringAck

Review URL: https://codereview.chromium.org/78903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236634 0039d316-1c4b-4281-b951-d872f2087c98
Fix multiline text offset calculation

This was broken since r232374.

BUG=320850

Review URL: https://codereview.chromium.org/75233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236635 0039d316-1c4b-4281-b951-d872f2087c98
Fix bugs in Native Messaging documentation

1. Path was not excaped properly in the example manifest file.
2. Docs didn't specify how a native messaging host can respond to a message
   sent using sendNativeMessage().

BUG=312884, 311266
R=mpcomplete@chromium.org

Review URL: https://codereview.chromium.org/79083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236636 0039d316-1c4b-4281-b951-d872f2087c98
Ensure using chrome://thumb2/... adds the URL as a forced URL in TopSites so that a thumbnail is captured next time it is visited.

Following up on patches:
- https://codereview.chromium.org/53283004/
- https://codereview.chromium.org/39053005/

BUG=

Review URL: https://codereview.chromium.org/59903010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236639 0039d316-1c4b-4281-b951-d872f2087c98
Android infobar cleanup:

* Don't return values callers don't use
* Rename a temp in anticipation of refactor patch
* Use Pass() where PassAs<>() is not necessary
* Minor comment/whitespace changes
* Don't NULL-check web_contents() when we're owned (should never be NULL)
* Don't bother storing delegate pointers on infobar subclasses, just downcast
  the base class' pointer (matches other platforms)
* Remove unnecessary DCHECKs (either other code performs them or they will no
  longer be necesssary in the refactored world)
* Remove unnecessary temps
* Speed up vector manipulation by not creating a bunch of objects we then
  overwrite
* DCHECK(expected, actual)

BUG=none
TEST=none
R=miguelg@chromium.org

Review URL: https://codereview.chromium.org/77773005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236640 0039d316-1c4b-4281-b951-d872f2087c98
Pepper: Use QuotaFileIO for SetLength, FileUtilProxy for Touch.
Now that FileIO is in the browser, we can use QuotaFileIO for SetLength and
FileUtilProxy for Touch.

Previously, we allowed SetLength without quota checks, and without even
opening the file with write access.

In order for Touch to succeed on Windows, we must set the
FILE_WRITE_ATTRIBUTES flag when we translate from Pepper open flags to
PlatformFile flags. Since the Pepper docs indicate that Touch should
succeed without write access, we always allow FILE_WRITE_ATTRIBUTES.
This should be OK since there is no way for untrusted apps to set
attributes other than file times.

BUG=313426

Review URL: https://codereview.chromium.org/79543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236641 0039d316-1c4b-4281-b951-d872f2087c98
Removed unused code path.

reuse_existing_data is never set true.
It should be removed with https://codereview.chromium.org/26558003

Review URL: https://codereview.chromium.org/81563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236642 0039d316-1c4b-4281-b951-d872f2087c98