I would say ignore it. There are a few places where the linter and pep8 can
only figure out so much without actually running the code.


On Tue, Apr 2, 2013 at 10:52 AM, Michael Tripoli
<notifications@github.com>wrote:

> In aminator/util/linux.py:
>
> > @@ -345,7 +352,7 @@ def install_provision_config(src, dstpath, backup_ext='_aminator'):
> >                      return False
> >              shutil.copy(src, dst)
> >          except Exception, e:
> > -            log.exception('Error encountered while copying {0} to {1}'.format(src, dst))
> > +            log.exception('Error encountered while copying {0} to {1}: {2}'.format(src, dst, e))
>
> These changes were because linter complained about 'e' not being used.
> Sent from my iPhone On Apr 2, 2013, at 10:15, Brian Moyles <
> notifications@github.com> wrote: In aminator/util/linux.py:
>  @@ -345,7 +352,7 @@ def install_provision_config(src, dstpath,
> backup_ext='_aminator'): return False shutil.copy(src, dst) except
> Exception, e: - log.exception('Error encountered while copying {0} to
> {1}'.format(src, dst)) + log.exception('Error encountered while copying {0}
> to {1}: {2}'.format(src, dst, e))
> With logger.exception, you shouldn't need to pass in the exception:
> http://docs.python.org/2/library/logging.html#logging.Logger.exception"Logs a message with level ERROR on this logger. The arguments are
> interpreted as for debug(). Exception info is added to the logging message.
> This method should only be called from an exception handler." — Reply to
> this email directly or view it on GitHub<
> https://github.com/Netflix/aminator/pull/38/files#r3622217> .
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Netflix/aminator/pull/38/files#r3622952>
> .
>