worked on generator and views