Aidan there is a reason for the more than 8  space indentation in line
break . This is the standard practice re kernel coding style :

Statements longer than 80 columns will be broken into sensible chunks, unless
exceeding 80 columns significantly increases readability and does not hide
information. Descendants are always substantially shorter than the parent and
are placed substantially to the right. The same applies to function headers
with a long argument list.




On 12 August 2013 10:51, Aidan Shribman <notifications@github.com> wrote:

> In drivers/heca/base.c:
>
> >
> > -    mutex_lock(&dsm_state->dsm_state_mutex);
> > -    list_del(&dsm->dsm_ptr);
> > -    radix_tree_delete(&dsm_state->dsm_tree_root, (unsigned long) dsm->dsm_id);
> > -    mutex_unlock(&dsm_state->dsm_state_mutex);
> > -    synchronize_rcu();
> > +        mutex_lock(&dsm_state->dsm_state_mutex);
> > +        list_del(&dsm->dsm_ptr);
> > +        radix_tree_delete(&dsm_state->dsm_tree_root,
> > +                        (unsigned long) dsm->dsm_id);
>
> Should be 8 indentation - not more
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/hecatonchire/linux-heca/pull/29/files#r5705974>
> .
>



-- 

Dr. Benoit Hudzia

M +44 (0)79 834 46729
<benoit.hudzia@sap.com>

mailto:benoit.hudzia@gmail.com <benoit.hudzia@sap.com>