I like the change l4_comp_csum, although “l4” looking to much like “14”, so either L4_comp_csum, or level4_comp_csum?
It also makes sense to add a L3 checksum for IPv4, otherwise I can’t union IPv4vars with IPv6vars as setting the csum in IPv4 will then clobber IPv6 data.

-Ken

From: Victor Julien [mailto:notifications@github.com]
Sent: Monday, November 18, 2013 8:08 AM
To: inliniac/suricata
Cc: Kenneth Steele
Subject: Re: [suricata] Share Packet checksum values for TCP, UDP, IPv6. ICMPv4 and ICMPv6 (#627)


In src/decode.h:

> @@ -427,6 +427,9 @@ enum PktSrcEnum {

>      /* header pointers */

>      EthernetHdr *ethh;

>

> +    /* Check sum for TCP, UDP or ICMP packets */

> +    int32_t comp_csum;

Post-merge comment: maybe we can call this l4_comp_csum and add a l3_comp_csum (which would apply only to ipv4 currently).

—
Reply to this email directly or view it on GitHub<https://github.com/inliniac/suricata/pull/627/files#r7723286>.