Sorry we didn't see the commit earlier - GitHub notifies on comments, but
not on commits, so you have to comments very time you add a commit if you
want people to see it.

Chuck is referring to the test failures linked from the PR page.
On 9 Jun 2013 16:03, "Charles Harris" <notifications@github.com> wrote:

> In numpy/lib/tests/test_io.py:
>
> > @@ -375,6 +375,19 @@ def test_complex_arrays(self):
> >                  [b'(3.142e+00+2.718e+00j) (3.142e+00+2.718e+00j)\n',
> >                   b'(3.142e+00+2.718e+00j) (3.142e+00+2.718e+00j)\n'])
> >
> > +    def test_custom_writer(self):
> > +
> > +        class CustomWriter(list):
> > +            def write(self, text):
> > +                self.extend(text.split('\n'))
>
> Looks like this needs b'\n' for python3, evidently the array is converted
> to a byte string.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/numpy/numpy/pull/3397/files#r4604280>
> .
>