After our earlier thread, I thought the PR was correct as it stood -- what did I miss?

As submitted it never returns zero from `physical_processor_count` and instead returns logical `processor_count` when physicals can't be determined.  The spec tests already assert that the value is in range `1..999` (which someday in the next decade or two will be inappropriately low :) which covers a `!= 0` assertion, and that logicals are an integral multiple of physicals (assuming symmetric multiprocessing).