When I submitted it I thought it was fine. After I updated it for the change in standards, I thought it was fine.

When I was told it was going to be pulled, I thought it was fine.

I'm really just trying to fix a bug that has been in my plugin for nearly 5 months now. The last minute changes on what to name an enum seem somewhat not needed.

Here are my suggestions for the problems:
1) Remove the isGaining method to avoid extra information (considering it just reads what enum value was passed anyways)
2) In regards to POTION - It is used for both consumed and splash potions. If I'm not mistaken there is a way already in the API to determine whether or not it's a splash (if not, POTION_SPLASH and POTION_CONSUMED are my suggestions)

I'm open to opinions, but I'm really looking to fix that bug in my plugin.