Created an edit_cms permission so non-admins can edit CMS pages #WEB-4753
Oooops. Debugging info pepper in the code.
Bah, I totally moved past the file-download ticket too quickly. This just leaves notes for the pieces that were missing. Sorry.
WIP ... just starting, new view specs are the coolest here.
WIP ... Making lots of progress moving all the specs out of taxa_page_spec (godawful thing that it is) to all the other specs where they belong.
Major strides, major strides... but so much more to do. Sigh.
Last run had ten failures, which is quite a bit down from what it was before, so I'm pleased... but not done. Still can't upgrade Rails until we're green, dammit.
1642 examples, 0 failures, 117 pending. Booyah.  ...Yeah, it onlny took me two weeks.  Sigh.
Fixing a few stray failures... and leaving in a few debugs for more failures that seem to be pretty rare, sigh.
Yup, another Debug statement to catch a pesky rare error. Grrr.
Adding some more debuggers for failing specs. Alas. ...This one's not terribly much worth fixing, since these specs should really be moved to view specs, but that's also a lot of work (there are many involved) so I'm leaving it for now.
WIP.  Not functional.
Whoa! Creates defaults!  ...I'm excited about that.  ...However, it doesn't (yet) check for duplicates.  Grrr.
Works! We now have a generalized enum for Vetted and KnownUri (arbitrarily chosen), including a few neat perks. ...Creates find methods for each of them and a #create_defaults method for testing and populating production (skips duplicates). Nice, general solution. ...Will now apply it to more classes.
enum_defaults now handles more intense default hashes (you now pass an array of hashes instead of just a hash) and fixed a few small bugs. This version allows you to explicitly name the methods created (when you supply a hash), which proved useful for DataType. Checked that strange cases work as expected (ie: GBIF Image => gbif_image). Added #set_defaults to Visibility and DataType.  Still many more to add it to...
added 'check_exists_by' param to #set_defaults to handle License. Grrr.
Added LinkType and Activity. ...Pausing after that last one because it's pretty intense... so I'm going to run tests now.
Tweaking a few suspect specs
Ooops... missing a return on that last commit
Okay, all #create_defaults have migrated over to EnumDefaults. Also, EnumDefaults no longer needs to be told when there are translations; it detects it.