[Chromium] Remove support for TRACE_EVENT_IF_LONGER_THANx macros
https://bugs.webkit.org/show_bug.cgi?id=104784

Reviewed by Pavel Feldman.

Source/Platform:

- remove threshold and id of related begin event from arguments of addTraceEvent()
- do not return the index of added event from addTraceEvent()

* chromium/public/Platform.h:
(Platform):
(WebKit::Platform::addTraceEvent):

Source/WebCore:

- removed TRACE_EVENT_IF_LONGER_THANx macros;
- changed addTraceEvent() to return void, as we no longer need the index of added event.

* platform/EventTracer.h:
(EventTracer):
* platform/chromium/EventTracerChromium.cpp:
(WebCore::EventTracer::addTraceEvent):
* platform/chromium/TraceEvent.h:
(TraceEvent):
(WebCore::TraceEvent::addTraceEvent):
(WebCore::TraceEvent::TraceEndOnScopeClose::addEventIfEnabled):
(Data):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt][WK1]REGRESSION(r137811): compositing/tiling/crash-huge-layer.html makes the following test crash on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=105158

Unreviewed gardening, skip the culprit test to paint the bots green.

* platform/qt-5.0-wk1/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: Popup flickers when cursor moves between elements with same anchor.
https://bugs.webkit.org/show_bug.cgi?id=104992

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-17
Reviewed by Pavel Feldman.

Popup disappears and then appears again when mouse pointer traverses
between sub-elements of anchor element.

* inspector/front-end/Popover.js: Split method "_mouseOut".
(WebInspector.PopoverHelper.prototype._popoverMouseOut):
Handler for Popover.
(WebInspector.PopoverHelper.prototype._mouseOut):
Handler for PopoverHelper.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, add myself to committers.py.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add manual test to verify that geometry methods (moveTo, etc) work
https://bugs.webkit.org/show_bug.cgi?id=105160

Reviewed by Alexis Menard.

* ManualTests/window-geometry.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Texmap] Drawing of ARB textures broken after r137498.
https://bugs.webkit.org/show_bug.cgi?id=105165

Disable antialiasing for ARB textures after unifying
code paths. We are currently missing a fragment shader
to do antialiasing with ARB textures.

Reviewed by Kenneth Rohde Christiansen.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexture):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[WK2] Enable tests that use boolean overridePreference
https://bugs.webkit.org/show_bug.cgi?id=105008

Unreviewed gardening. Enable tests that call overridePreference()
with a boolean value, mostly webgl ones. Add a few fail results for
EFL.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-17

* platform/efl/TestExpectations:
* platform/wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: Persist Audit selections across sessions
https://bugs.webkit.org/show_bug.cgi?id=103944

Reviewed by Alexander Pavlov.

Make selected audit categories a persistent setting, to simplify life for those
repeatedly running same set of categories.

* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView):
(WebInspector.AuditLauncherView.prototype.addCategory.get var):
(WebInspector.AuditLauncherView.prototype.addCategory):
(WebInspector.AuditLauncherView.prototype._selectAllClicked):
(WebInspector.AuditLauncherView.prototype._categoryClicked):
(WebInspector.AuditLauncherView.prototype._createCategoryElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add Anton Vayvod and Tim Volodine as contributors in committers.py
https://bugs.webkit.org/show_bug.cgi?id=105025

Unreviewed. Adds two contributors to committers.py.
They are initially contributing to the Text Autosizing feature (master bug: 84186).

Patch by John Mellor <johnme@chromium.org> on 2012-12-17

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: Make popover content accessible for clicks.
https://bugs.webkit.org/show_bug.cgi?id=105167

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-17
Reviewed by Vsevolod Vlasov.

Currently it is very hard to move mouse pointer inside of popover area.
The only maneuver is to precisely jerk the mouse in direction of popover.

This path makes anchor and popover "active" areas overlap, so it becomes
possible to smoothly move mouse to popover interior.

* inspector/front-end/Popover.js:
(WebInspector.Popover.prototype._innerShow): Make popover "outer" border
an be "active" area.
* inspector/front-end/popover.css: Allow popover "outer" border receive
mouse events.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[WK2] TiledBackingStore: css3/device-adapt/viewport-width-not-affecting-next-page.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=105131

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

The problem was lead by truncation of the scaled result for 'contentFixedSize'.
Fixed now with using FloatSize::scale() instead of IntSize::scale().

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):

LayoutTests:

Unskipped css3/device-adapt/viewport-width-not-affecting-next-page.html for WK2 EFL.

* platform/efl-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt][WK2] compositing/overflow/automatically-opt-into-composited-scrolling.html makes other tests fail
https://bugs.webkit.org/show_bug.cgi?id=105173

Unreviewed gardening, skip the culprit tests to paint the bots green.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Blackberry] Static code analysis warning fixes
https://bugs.webkit.org/show_bug.cgi?id=105129

Patch by Anthony Scian <ascian@rim.com> on 2012-12-17
Reviewed by Rob Buis.

Source/WebCore:

- alloca can return NULL, recoded to just use a temp var

* plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::updateBuffer):

Source/WebKit/blackberry:

- disable copy/op= in BackingStore
- cache and check intermediate values in parentLayer
- disable copy/op= in InRegionScroller
- disable copy/op= in WebPageGroupLoadDeferrer
- disable copy/op= in WebSettings
- disable copy/op= in WebViewportArguments
- disable copy/op= in BackingStoreClient
- disable copy/op= in TileBuffer
- if stopNode is not NULL, loop could iterate past NULL; added NULL check to loop
  to make the code more robust

* Api/BackingStore.h:
* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
(BlackBerry::WebKit::parentLayer):
* Api/InRegionScroller.h:
* Api/WebPageGroupLoadDeferrer.h:
* Api/WebSettings.h:
* Api/WebViewportArguments.h:
* WebKitSupport/BackingStoreClient.h:
(BackingStoreClient):
* WebKitSupport/BackingStoreTile.h:
(TileBuffer):
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::visibleTextQuads):

Tools:

Added null checks for fopen calls, no recovery attempted; access fault prevention only.

* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::createFile):
(BlackBerry::WebKit::DumpRenderTree::runTest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Attribute: Remove unused constructor and isNull().
<http://webkit.org/b/105179>

Reviewed by Antti Koivisto.

Removed the Attribute constructor that takes a localName rather than a full QualifiedName as that was never used.
Also removed Attribute::isNull(), since that was only called in one place where isNull() will never be true.

* dom/Attribute.h:
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::collectStyleForPresentationAttribute):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt][WK2] Unreviewed gardening.

* platform/qt-5.0-wk2/TestExpectations: Skip a new failing test.
* platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt: Added because of minor pixel differences.
* platform/qt-5.0-wk2/fast/images/crossfade-client-not-removed-crash-expected.txt: Added WK2 specific result.
* platform/qt-5.0-wk2/fast/text/zero-font-size-expected.txt: Added after r137902.
* platform/qt-5.0-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Updated.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
https://bugs.webkit.org/show_bug.cgi?id=105026

Reviewed by Yury Semikhatsky.

Old SFINAE test was replaced with new one based on this article:
http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions

Source/WTF:

* wtf/MemoryInstrumentation.h:
(MemoryInstrumentation):
(yes):
(IsInstrumented):
(no):
(WTF::MemoryInstrumentation::IsInstrumented::BaseMixin::reportMemoryUsage):
(WTF::MemoryInstrumentation::selectInstrumentationMethod):
(InstrumentationSelector):
(WTF):
(WTF::::reportObjectMemoryUsage):

Tools:

New test which covers this problem was added.

* TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: [chromium] make toolbar render with Mountain Lion-friendly colors
https://bugs.webkit.org/show_bug.cgi?id=105177

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/UIUtils.js:
(WebInspector.platformFlavor):
* inspector/front-end/inspector.css:
(#toolbar):
(body.dock-to-bottom #toolbar):
(.toolbar-item):

Source/WebKit/chromium:

* src/js/devTools.css:
(body.dock-to-bottom #toolbar):
(body.undocked.platform-mac-leopard #toolbar):
(body.undocked.platform-mac-leopard.inactive #toolbar):
(body.undocked.platform-mac-snowleopard #toolbar):
(body.undocked.platform-mac-snowleopard.inactive #toolbar):
(body.undocked.platform-mac-mountain-lion #toolbar):
(body.undocked.platform-mac-mountain-lion.inactive #toolbar):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: Provide the paint count of layers through the LayerTreeAgent
https://bugs.webkit.org/show_bug.cgi?id=105024

Patch by Antoine Quint <graouts@apple.com> on 2012-12-17
Reviewed by Pavel Feldman.

Source/WebCore:

We add a new optional .paintCount property to the Layer object, passing through the
relevant information from GraphicsLayer.

* inspector/Inspector.json:
* inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):

LayoutTests:

Add the paintCount property to the expected output of the LayerTreeAgent test.

* inspector-protocol/layer-tree-expected.txt:
* inspector-protocol/layer-tree.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[CSS Exclusions] Add helper functions for converting floats to LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=103450

Patch by Hans Muller <hmuller@adobe.com> on 2012-12-17
Reviewed by Dirk Schulze.

When a float logicalTop value is converted to a LayoutUnit it's necessary to
use LayoutUnit::fromFloatCeil() to ensure that we're snapping to a value that's
inside the ExclusionShape.  Similarly, to convert a logicalBottom value from
float to LayoutUnit we use LayoutUnit::fromFloatFloor().  Added a pair of private
ExlcusionShapeInsideInfo methods that do the conversions and refactored existing
code to use them.

This is just a cleanup.  No new tests are needed, the existing tests cover
these changes.

* rendering/ExclusionShapeInsideInfo.cpp:
(WebCore::ExclusionShapeInsideInfo::adjustLogicalLineTop): Use the new floatLogicalTopToLayoutUnit() method.
* rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::shapeLogicalTop): Use the new floatLogicalTopToLayoutUnit() method.
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBottom): Use the new floatLogicalBottomToLayoutUnit() method.
(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::floatLogicalTopToLayoutUnit): Convert a float to a LayoutUnit with LayoutUnit::fromFloatCeil().
(WebCore::ExclusionShapeInsideInfo::floatLogicalBottomToLayoutUnit): Convert a float to a LayoutUnit with LayoutUnit::fromFloatFloor().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
GraphicsLayer's repaint count should update even when debugging option to show it is off
https://bugs.webkit.org/show_bug.cgi?id=105178

Patch by Antoine Quint <graouts@apple.com> on 2012-12-17
Reviewed by Simon Fraser.

Update the repain count even if the debug option to show them is turned off.
This allows the count to be accurate in between toggles of the debug option
and to allow the InspectorLayerTreeAgent to get accurate results any time
the layer tree is requested (see webkit.org/b/105024).

* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137915 268f45cc-cd09-0410-ab3c-d52691b4dbfc