I think you should make the change anyway.  The method CanForget is
explicitly meant to prevent spells from being forgotten, and by ignoring
CanForget here (which is in fact the only place it is called), it means
that any future changes to CanForget won't work.  Let's try to avoid
surprises years from now.


On Thu, Jul 4, 2013 at 8:36 PM, theanax <notifications@github.com> wrote:

> In kod/object/item/passitem/pforget.kod:
>
> > @@ -135,7 +135,7 @@ messages:
> >           oSpell = send(SYS,@FindSpellByNum,#num=iSpellNum);
> >
> >           if send(oSpell,@GetSchool) = viForget_School
> > -            AND send(oSpell,@CanForget)  %% riija potion doesn't wipe blink
> > +            AND NOT send(oSpell,@IsGivenFreeToNewPlayers)  %% Don't wipe default spells.
>
> Just tested this. DM spells are not forgotten.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Meridian59/Meridian59/pull/207/files#r5037637>
> .
>