Done.
I also defaulted wait to True in stop.stop, since there since to be no way
for the runner to pass it in and waiting seems like the most sensible thing
to do. Else options like this and --clean have no use.

Jorge


On Tue, Jun 11, 2013 at 1:41 PM, elmirjagudin <notifications@github.com>wrote:

> In master/buildbot/scripts/stop.py:
>
> > @@ -25,6 +25,13 @@ def stop(config, signame="TERM", wait=False):
> >      basedir = config['basedir']
> >      quiet = config['quiet']
> >
> > +    try:
> > +      timeout = int(config['timeout'])
> > +      wait = True
> > +    except ValueError:
> > +      raise ValueError('timeout option has must be an integer. Received: ' +
> > +                       str(config['timeout']))
> > +
>
> I think it's better to do the parameter validation in
> buildbot.scripts.runner.StopOptions class. Add a new method
> StopOptions.postOptions() and move this code there. Raise usage.UsageError
> exception on non-integer parameter. Maybe we should also check for negative
> timeouts.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/buildbot/buildbot/pull/761/files#r4643787>
> .
>