Add function Toadlet.sendUnauthorizedPage() as inspired from DarknetAddRefToadlet. This should be used instead of manually copypasting sendErrorPage(...) everywhere.
Use sendUnauthorizedPage instead of copypasta of super.sendErrorPage(...) in all Toadlets:
- I decided against prefixing all calls with "super." because when reading a large codebase one typically does not care whether such functions are in the super class or not. And if it matters, one will find out anyway when hitting F3 on them to go to their location.
- Notice that this fixes some cases of hardcoded English strings instead of using l10n.
- Notice that PproxyToadlet had duplicated the l10n Strings for unauthorized messages. So this commit removes them from the l10n files.
Add attribution that got left out somehow when merging
Verify the generated ClientSSKBlock if logMINOR. I've seen local SSKs rejected, need to eliminate theories...
Zero out the computedExponential (master key from connection setup) once we no longer need it.
Turn off NLM messages for now.
Toadlet.sendUnauthorizedPage:
- Add JavaDoc
- Increase visibility so ToadletContextImpl can use it in the following commit
Add function ToadletContext.checkFullAccess similar to checkFormPassword
- Unfortunately, this has to use the sendUnauthorizedPage of class Toadlet since the error sending code in ToadletContextImpl is not good (generates HTML using hardcoded Strings)
Use the new ToadletContext.checkFullAccess(this) instead of isAllowedFullAccess()+sendUnauthorizedPage()
Remove unused function
Merge remote-tracking branch 'xor/toadlet-security' into next