honestly I think it looks pretty confusing redundant too, I didn't came up
with that myself, just found something related in stackoverflow :) so far
seems to work well.


On Mon, Sep 9, 2013 at 8:31 PM, Ryan Bigg <notifications@github.com> wrote:

> In core/app/models/spree/shipment.rb:
>
> > @@ -154,7 +154,7 @@ def editable_by?(user)
> >      end
> >
> >      def manifest
> > -      inventory_units.includes(:variant).group_by(&:variant).map do |variant, units|
> > +      inventory_units.joins(:variant).includes(:variant).group_by(&:variant).map do |variant, units|
>
> Well I'll be damned. I never considered that using includes and joinswould
> *NOT* have any adverse effects. If this fixes the issue, as @daddeo2<https://github.com/daddeo2>confirmed over in
> #3673 <https://github.com/spree/spree/issues/3673>, then I say we merge
> it.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/spree/spree/pull/3687/files#r6254291>
> .
>



-- 
Washington L Braga Jr

Developer
Spree Commerce, Inc.