Make lvm2 plugin lvmdump option collect metadata

The lvmdump-a option currently collects 'advanced' data but not
raw metadata. Since it's off by default and the metadata is often
of interest in support cases rename the option to lvmdump-am and
have it also pass the '-m' (raw metadata) option to the lvmdump
script.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Rationalise lvm2 plug-in lvmdump options

The lvm2 lvmdump options were a bit crazy, allowing the user to
specify a default ('lvmdump'), or an advanced collection
('lvmdump-a') but not the raw metadata ('-m') option which is
often useful for support purposes.

Replace 'lvmdump-a' with 'lvmdump-am' to collect both.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Improve readability of add_copy_specs() usage in ldap.py

Use multi-line style for add_copy_specs() invocations in the ldap
plug-in per the recommendations in Issue #173.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Add pam_ldap.conf collection to ldap plug-in

Add the pam_ldap.conf file to the data collected by the ldap
plug-in and tidy up substitution strings for this plug-in.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Make 'ipsec barf' collection non-default in openswan plug-in

The 'ipsec barf' debugging command has a nasty bug where it runs
grep on /var/log/lastlog. Since this can be a multi-gigabyte
sparse file this doesn't work very well and consumes huge amounts
of memory. This can lead to timeouts and aborts when running sos
since the openswan plug-in calls this command by default.

The barf information is seldom useful anyway - turn it off by
default to avoid this problem.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Collect saved vmcore-dmesg.txt files in kdump plug-in

Recent versions of kexec-utils automatically generate a text
file containing the dmesg buffer of the captured vmcore.

This is useful for first-fault debugging and should be included.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Add new patterns to the RPM plug-in verify list

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Do not attempt to read use-gss-proxy file in procfs

The networking plug-in scoops up /proc/net. There are some pseudo-
files in here that we should avoid touching. These either have
side-effects or hang the reading process.

Add a forbidden path for the /proc/net/rpc/use-gss-proxy file.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Do not attempt to read use-gss-proxy file in procfs

The networking plug-in scoops up /proc/net. There are some pseudo-
files in here that we should avoid touching. These either have
side-effects or hang the reading process.

Add a forbidden path for the /proc/net/rpc/*/{channel,flush}
files as these will cause side-effects for RPC applications
running on the host.

Forward port of commit 61585d4 on rhel-6 branch.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>