adding attributes work in progress