added support for more attributes

Signed-off-by: khalid <mustkre8@gmail.com>