I think you should merge the two, im confused.


On Tue, Feb 12, 2013 at 3:55 PM, Solinx <notifications@github.com> wrote:

> In system/cms/modules/contact/models/contact_m.php:
>
> >  	
> > -	public function get_log()
> > -	{
> > -		return $this->db
> > -			->get('contact_log')
> > -			->result();
> > -	}
> > -	
> > -	public function insert_log($input)
>
> @philsturgeon <https://github.com/philsturgeon>
>
> Actually. It turns out I did intentionally remove this method. I removed
> it to accomodate the pull request for the contact plugin, which was not
> included into this request because it involves plenty of non-eloquent
> related changes and fixes: #2349<https://github.com/pyrocms/pyrocms/issues/2349>
> .
>
> I did indeed break things in this single pull request by using $data in
> the plugin, instead of the prepared array as in the insert_log method. For
> what it is worth I've fixed that now, although it does not matter much if
> you're going to accept the contact plugin pull request later on.
>
> You could argue I should have kept the two better separated, but
> considering the changes to the plugin involve changes to the data array
> that was rather impossible to do.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pyrocms/pyrocms/pull/2346/files#r2985227>.
>
>