Good point.  and also seeing the lines above we should remove the sys.stderr.write to conform to other error handling in the client.


On Sep 19, 2013, at 4:57 PM, kaysoky wrote:

> In synapseclient/evaluation.py:
> 
> > @@ -91,6 +91,8 @@ def __init__(self, **kwargs):
> >          if  kwargs['status'] not in ['OPEN', 'PLANNED', 'CLOSED', 'COMPLETED']:
> >              sys.stderr.write('\nEvaluation Status must be one of [OPEN, PLANNED, CLOSED, COMPLETED]\n\n')
> >              raise ValueError
> > +        if not kwargs['contentSource'].startswith('syn'):   #Verify that synapse Id given
> > +            raise ValueError
> We could use a better error message, i.e:
> 
> raise ValueError("The 'contentSource' parameter must be specified when creating an Evaluation")
> 
> —
> Reply to this email directly or view it on GitHub.
>