> That's not entirely true, since whether the attachment will be saved or not is determined from the MIME type. So if you have disabled file attachments, but snapshots are on, you would then end up downloading the entire PDF (for example) and choose to discard it. At least that's the reason that I thought this was implemented the way it is.

I don't totally follow this. At least once we get to importFromURL(), the only time we discard something is if it's not a PDF and we expected it to be, and that only happens once the file has been saved, using ``Zotero.File.getSample(file)``. If file attachments are off, why would we download a PDF to begin with? You mean specifically with regard to something like RIS, where it could be an arbitrary file? Does the snapshot pref even apply to RIS? (I pretty much just know about attachments.js here, not the rest of the translator architecture, so some of these may be stupid questions.)

I'll defer to @simonster on pushing this as is now.