Problem being that we have our own key repeat logic for held buttons. So we
can't send key up events to xbmc, then we don't get the held effect.


On Mon, Oct 28, 2013 at 4:35 AM, smspillaz <notifications@github.com> wrote:

> In xbmc/windowing/WinEventsX11.cpp:
>
> > +        break;
> > +      } //KeyPress
> > +
> > +      case KeyRelease:
> > +      {
> > +        // if we have a queued press directly after, this is a repeat
> > +        if( XEventsQueued( WinEvents->m_display, QueuedAfterReading ) )
> > +        {
> > +          XEvent next_event;
> > +          XPeekEvent( WinEvents->m_display, &next_event );
> > +          if(next_event.type == KeyPress
> > +            && next_event.xkey.window == xevent.xkey.window
> > +            && next_event.xkey.keycode == xevent.xkey.keycode
> > +            && (next_event.xkey.time - xevent.xkey.time < 2) )
> > +            continue;
> > +        }
>
> Is there a reason why we don't respect the system level key repeat setting?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xbmc/xbmc/pull/3505/files#r7239681>
> .
>