I'd be inclined to add defaults rather than remove unless we hit obstacles. The "value" attribute is indeed optional so long as all the others are provided and having the default value is Java's way of signifying that it is optional - so I'd leave as is.

Cheers, Paul.

On 25/11/2013 7:42 AM, PascalSchumacher wrote:
> In src/main/groovy/lang/GrabExclude.java:
>
>>      /**
>> -     * Allows a more compact convenience format in one of two formats,
>> -     * e.g.: "org.apache.ant:ant-junit" or "org.apache.ant#ant-junit".
>> +     * Allows to specify the group (organisation) and the module (artifact) in a two compact convenience formats,
>> +     * e.g.: <code>@GrabExclude('org.apache.ant:ant-junit')</code> or <code>@GrabExclude('org.apache.ant#ant-junit')</code>
>>       */
>>      String value() default "";
>
> Maybe the default should also be removed?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/groovy/groovy-core/pull/286/files#r7880366>.
>