Right!

On 04/17/2013 04:48 PM, James Taylor wrote:
>
> In src/main/java/com/salesforce/phoenix/schema/SaltingUtil.java:
>
> > +import java.util.Arrays;
> > +import java.util.List;
> > +
> > +import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
> > +
> > +import com.google.common.collect.Lists;
> > +import com.salesforce.phoenix.query.KeyRange;
> > +import com.salesforce.phoenix.util.ByteUtil;
> > +
> > +
> > +/**
> > + * Utility methods related to transparent salting of row keys.
> > + */
> > +public class SaltingUtil {
> > +
> > +    public static final Integer MAX_BUCKET_NUM = 255; // Unsigned byte.
>
> This should be 256, b/c we're mod-ing with this to force the byte to 
> be from 0 -> 255, right?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/forcedotcom/phoenix/pull/139/files#r3844517>.
>