Wilko.  I'll put more in.

Cheers, Andrew

*Andrew Harmel-Law*
twitter: @al94781 <http://twitter.com/al94781>
blog: the-music-of-time.blogspot.com
flickr: flickr.com/photos/andrewbrucelaw


On 6 March 2013 21:56, Justin Ryan <notifications@github.com> wrote:

> In
> job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContextHelper.groovy:
>
> > @@ -332,6 +332,45 @@ class PublisherContextHelper extends AbstractContextHelper<PublisherContextHelpe
> >          }
> >
> >          /**
> > +         * Clone Workspace SCM
> > +         *
> > +         * <hudson.plugins.cloneworkspace.CloneWorkspacePublisher>
> > +         * <workspaceGlob></workspaceGlob>
> > +         * <workspaceExcludeGlob></workspaceExcludeGlob>
> > +         * <criteria>Any</criteria>
> > +         * <archiveMethod>TAR</archiveMethod>
> > +         * <overrideDefaultExcludes>true</overrideDefaultExcludes>
> > +         * </hudson.plugins.cloneworkspace.CloneWorkspacePublisher>
> > +         */
> > +        def publishCloneWorkspace(String workspaceGlob, Closure cloneWorkspaceClosure) {
> > +            publishCloneWorkspace(workspaceGlob, '', 'Any', 'TAR', false, null)
> > +        }
> > +
> > +        def publishCloneWorkspace(String workspaceGlobArg, String workspaceExcludeGlobArg = '', String criteriaArg = 'Any', String archiveMethodArg = 'TAR', boolean overrideDefaultExcludesArg = false, Closure cloneWorkspaceClosure = null) {
>
> I'd bet that not every arg is needed together, but that aside it's still
> better to have multiple methods solely because you're providing default
> values. That's what require overridden methods. If you remove the defaults
> then it would make sense to only have two method calls. But I wouldn't do
> that.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jenkinsci/job-dsl-plugin/pull/36/files#r3270457>
> .
>