Disable notification because it caused ASAN errors.

NOTRY=true
R=kkania@chromium.org
TBR=kkania

Review URL: https://codereview.chromium.org/24257006

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224241 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Don't enable zero suggest if a user has a custom sync passphrase (because the user might not want unencrypted URLs to be sent to Google).  Also only require open tab sync to enable zero suggest (instead of requiring everything to be synced).

BUG=290410

Review URL: https://chromiumcodereview.appspot.com/23819051

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224245 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Send configuration stats together at the end of data type configuration so that
the stats will appear in one GWS log to make it easy to analyze.

BUG=236466

Review URL: https://chromiumcodereview.appspot.com/23866012

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224246 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Fix panel showing logic under full-screen mode
1) When the full-screen mode is on, all non-always-on-top detached/stacked panels
   should remain visible, while all always-on-top docked panels should become
   hidden. When the full-screen mode is off, all docked panels should become
   visible (Note: this is not needed on Linux).
2) When the full-screen mode is on, all newly created panels, regardless of docking
   or not, should not be shown. They will be shown after the full-screen mode is off.

New tests have been added to make sure the above behaviors work on all platforms.

BUG=256382
TEST=new tests

Review URL: https://chromiumcodereview.appspot.com/23891004

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224247 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Eliminate CHECK from CryptohomeLibrary::LoadSystemSalt

This change makes callers responsible for ensuring that the returned
system salt is valid.

It also includes removal of some stale unused code.

BUG=288210
For c/b/e/aoi/music_manager_private:
TBR=asargent@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23903051

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224248 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Don't persist HPKP if PrivacyMode is enabled.

BUG=258667

Review URL: https://chromiumcodereview.appspot.com/19269012

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224269 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Revert 224269 "Don't persist HPKP if PrivacyMode is enabled."

It broke Google Chrome ChromeOS bot.
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/58548/steps/compile/logs/stdio#error1
FAILED: g++ ... -c ../../net/socket/ssl_client_socket_nss.cc -o obj/net/socket/net.ssl_client_socket_nss.o
../../net/socket/ssl_client_socket_nss.cc: In member function 'int net::SSLClientSocketNSS::DoVerifyCertComplete(int)':
../../net/socket/ssl_client_socket_nss.cc:3445:64:error: no matching function for call to 'net::TransportSecurityState::GetDomainState(const string&, bool&, net::TransportSecurityState::DomainState*)'
../../net/socket/ssl_client_socket_nss.cc:3445:64: note: candidate is:
../../net/http/transport_security_state.h:212:8: note: bool net::TransportSecurityState::GetDomainState(const string&, bool, bool, net::TransportSecurityState::DomainState*)
../../net/http/transport_security_state.h:212:8: note:   candidate expects 4 arguments, 3 provided

> Don't persist HPKP if PrivacyMode is enabled.
> 
> BUG=258667
> 
> Review URL: https://chromiumcodereview.appspot.com/19269012

TBR=mef@chromium.org

Review URL: https://codereview.chromium.org/24251011

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224275 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Delete the installation directory if the installation fails.

This prevents us from leaving a partially-installed directory on the disk,
which can confuse future Chrome start-ups.

BUG=245318

Review URL: https://chromiumcodereview.appspot.com/23684052

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224280 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Fix incorrect file_util::WriteFile() checks.

Review URL: https://chromiumcodereview.appspot.com/23775008

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224281 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
[Activity log] Drop XMLHttpRequest.open from the argument whitelist

Do not keep all arguments for the XMLHttpRequest.open DOM call.  Usually
we will extract the URL argument into arg_url where it is accessible
even when arguments aren't kept.  Sometimes, however, the argument
contains a relative (not absolute) URL which can't be extracted.  In
this case, err on the side of privacy and do not log the URL at
all--rather than keeping the arguments around, where the URL is kept but
not sanitized or cleared with history.

Review URL: https://chromiumcodereview.appspot.com/23928006

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224282 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add UMA metrics for window selection and overview.

BUG=290995

Review URL: https://chromiumcodereview.appspot.com/24096024

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224287 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Rename WindowSettings to WindowState
Move window control methods from window_util.h to WindowState
Removed property_util which is no longer necessary.

BUG=272460

Review URL: https://chromiumcodereview.appspot.com/24108003

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224288 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Making OAuth2TokenService multi-login aware:
* Adding account_id as a parameter to public methods, like: StartRequestXX, RefreshTokenIsAvailable, GetRefreshToken, InvalidateToken,
* Updating callers and derived classes,
* Updating cache handling for the OAuth2 access tokens in OAuth2TokenService

BUG=277149

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224031

Review URL: https://chromiumcodereview.appspot.com/23382008

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224294 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Fix broken unit test

The unit test was checking against the end of the wrong iterator (perils
of using cut and paste while coding).  This change re-enables the test on
windows and fixes the bug.

BUG=294658

Review URL: https://chromiumcodereview.appspot.com/24130005

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224297 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
[Aura] Form validation bubble has extra border

We need to set the top level window as the parent of the bubble view
in order to draw bubble border correctly in Aura Windows.

BUG=290560

Review URL: https://chromiumcodereview.appspot.com/23717051

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224300 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
[rac] Fix the section container width: 420px

This patch changes the rac section container to be 420px to match mocks.
Previously, the width was 480px + proxy_button.width.

BUG=294467

Review URL: https://chromiumcodereview.appspot.com/23850005

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224301 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Extract ServiceDiscoverySharedClient interface.

Review URL: https://chromiumcodereview.appspot.com/24153021

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224305 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Discover local devices when privet notification service starts for real

Perform discovery when the privet notification service starts its lister, to
ensure the first device, which caused the lister to start, won't be lost.

BUG=245385

Review URL: https://chromiumcodereview.appspot.com/24222003

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224315 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Do not show popup when crashing force-installed extension is restarted

CL 23427003 added code that will restart a force-installed extension if it
crashes and will show a popup if multiple crashes occur within a short
time. UI objected to the use of this popup bubble and would like a
notification based on the GlobalErrorBubble to be used instead.

This CL removes the popup that UI vetoed. A GlobalErrorBubble will be
added in a separate CL, likely resurrecting some of the code that is
removed in this CL.

BUG=175701
TEST=None

Review URL: https://chromiumcodereview.appspot.com/24242003

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224320 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Don't show uninstall prompt in App Launcher unless caller asks.

Before this change the code will always show the uninstall prompt if the
app list is visible. This is bad for the case where the app launcher is
open and the user clicks the remove icon in chrome://extensions. Before
the app launcher has a chance to dismiss itself, it will have an
uninstall prompt shown underneath it.

This is doubly bad because the delegate will not notify the app launcher
that it has a dialog underneath it, so the app launcher can be dismissed
from behind the uninstall prompt.

BUG=292466

Review URL: https://chromiumcodereview.appspot.com/24244002

git-svn-id: http://src.chromium.org/svn/trunk/src/chrome/browser@224325 4ff67af0-8c30-449e-8e8b-ad334ec8d88c