agreed, left over from testing 

----- Original Message -----

From: "Nan Liu" <notifications@github.com> 
To: "vmware/vmware-vshield" <vmware-vshield@noreply.github.com> 
Cc: "sholland" <sholland@vmware.com> 
Sent: Monday, April 22, 2013 2:21:38 PM 
Subject: Re: [vmware-vshield] added useful error message when invalid ds is provided or no ds is found (#31) 



In lib/puppet/provider/vshield_edge/default.rb: 
>      else
> -      resource_pool.datastore.first
> +      ds = resource_pool.datastore.first or raise Puppet::Error, "no datastore found" 


is ds variable used? if not I would keep the same format as line 134. 

— 
Reply to this email directly or view it on GitHub .