Yes we can, changed.

On 04/16/2013 03:43 PM, James Taylor wrote:
>
> In src/main/java/com/salesforce/phoenix/compile/UpsertCompiler.java:
>
> > @@ -131,7 +137,7 @@ public MutationPlan compile(UpsertStatement upsert, List<Object> binds) throws S
> >              for (int i = 0; i < table.getPKColumns().size(); i++) {
> >                  PColumn pkCol = table.getPKColumns().get(i);
> >                  if (!pkColumnsSet.get(i)) {
> > -                    if (!pkCol.isNullable()) {
> > +                    if (!pkCol.isNullable() && !SaltingUtil.isSaltingColumn(pkCol)) {
>
> Can't we just start i at 1 if table.getBucketNum() != null rather than 
> check each time in the loop?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/forcedotcom/phoenix/pull/139/files#r3822944>.
>