OK, sounds good, merge it in.


On Tue, Aug 27, 2013 at 9:31 PM, Pavel Jbanov <notifications@github.com>wrote:

> In lib/block.dart:
>
> > @@ -1,6 +1,6 @@
> >  part of angular;
> >
> > -Symbol _SHADOW = new Symbol('SHADOW_INJECTOR');
> > +String _SHADOW = 'SHADOW_INJECTOR';
>
> I thought about that, but basically we no longer have direct access to
> injector internals and the injector marking is done with a String name
> (injectors can be named). Even if someone manually created an injector with
> the 'SHADOW_INJECTOR' name and passed it to the blockFactory it should not
> cause issues because at the shadow injector we would be 2 layers of
> injectors below that injector, so from the shadow injector we would walk up
> once and always find the nameless injector created in
> _instantiateDirectives.
>
> I should add a test for it. If you still have concerns about it we can
> chat about it tomorrow.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/angular/angular.dart/pull/95/files#r6025258>
> .
>