Never time out.

----------------
Stephen P. Henrie  mailto:shenrie@ucsd.edu
System Architect
Ocean Observatories Initiative Cyberinfrastructure Project: http://ci.oceanobservatories.org<http://ci.oceanobservatories.org/>

From: Jonathan Newbrough <notifications@github.com<mailto:notifications@github.com>>
Reply-To: ooici/coi-services <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Mon, 1 Apr 2013 11:46:24 -0700
To: ooici/coi-services <coi-services@noreply.github.com<mailto:coi-services@noreply.github.com>>
Cc: Stephen Henrie <shenrie@ucsd.edu<mailto:shenrie@ucsd.edu>>
Subject: Re: [coi-services] plumb timeout into agent tests that access using service gateway (#830)


In ion/agents/instrument/test/test_gateway_to_instrument_agent.py:

>
>          agent_cmd_params = IonObjectSerializer().serialize(cmd)
>
>          agent_execute_request = {  "agentRequest": {
>              "agentId": resource_id,
>              "agentOp": op,
> -            "expiry": 0,
> +#            "expiry": 0,


does the 0 value means the creds never time out or that they immediately timeout (this request only)?
…
On Mon, Apr 1, 2013 at 11:42 AM, shenrie <notifications@github.com<mailto:notifications@github.com>> wrote: In ion/agents/instrument/test/test_gateway_to_instrument_agent.py: > > agent_cmd_params = IonObjectSerializer().serialize(cmd) > > agent_execute_request = { "agentRequest": { > "agentId": resource_id, > "agentOp": op, > - "expiry": 0, > +# "expiry": 0, Well, now I am concerned that this was commented out in the service_api…that's no bueno. These are two different things. The expiry has to do with the how long the credentials are good for ( related to the requestor value ) and the timeout is specific to that request. It should not be commented out in either place. ---------------- Stephen P. Henrie mailto:shenrie@ucsd.edu System Architect Ocean Observatories Initiative Cyberinfrastructure Project: http://ci.oceanobservatories.org<http://ci.oceanobservatories.org/> From: Jonathan Newbrough <notifications@github.com<mailto:notifications@github.com><mailto: notifications@github.com<mailto:notifications@github.com>>> Reply-To: ooici/coi-services < reply@reply.github.com<mailto:reply@reply.github.com><mailto:reply@reply.github.com>> Date: Mon, 1 Apr 2013 11:38:58 -0700 To: ooici/coi-services < coi-services@noreply.github.com<mailto:coi-services@noreply.github.com><mailto:coi-services@noreply.github.com>> Cc: Stephen Henrie <shenrie@ucsd.edu<mailto:shenrie@ucsd.edu><mailto:shenrie@ucsd.edu>> Subject: Re: [coi-services] plumb timeout into agent tests that access using service gateway (#830<https://github.com/ooici/coi-services/issues/830> <https://github.com/ooici/coi-services/issues/830>) In ion/agents/instrument/test/test_gateway_to_instrument_agent.py: agent_cmd_params = IonObjectSerializer().serialize(cmd) agent_execute_request = { "agentRequest": { "agentId": resource_id, "agentOp": op, - "expiry": 0, +# "expiry": 0, just duplicated what i saw in service_api.py so the calls would be identical. i thought this was maybe the old-style of timeout, but i guess not. you want this uncommented? … On Mon, Apr 1, 2013 at 11:33 AM, shenrie < notifications@github.com<mailto:notifications@github.com><mailto:notifications@github.com>> wrote: In ion/agents/instrument/test/test_gateway_to_instrument_agent.py: > > agent_cmd_params = IonObjectSerializer().serialize(cmd) > > agent_execute_request = { "agentRequest": { > "agentId": resource_id, > "agentOp": op, > - "expiry": 0, > +# "expiry": 0, Why did you comment out this? A zero indicates to the framework that the credentials used by the request should not expire. I would think that you would want this for testing purposes. — Reply to this email directly or view it on GitHub< https://github.com/ooici/coi-services/pull/830/files#r3605660> . — Reply to this email directly or view it on GitHub< https://github.com/ooici/coi-services/pull/830/files#r3605773>. — Reply to this email directly or view it on GitHub<https://github.com/ooici/coi-services/pull/830/files#r3605866> .

—
Reply to this email directly or view it on GitHub<https://github.com/ooici/coi-services/pull/830/files#r3605957>.