[#53334909] Upgrade shoulda-matchers to 2.2.0

This allows (and requires) us to remove the crazy shoulda-matchers monkeypatch from spec_helper.