It is tested in other test, if I didn't put this in case this test should
fail Role would actually try to upload file to remote server.
jb:)


2013/2/13 Diogo Baeder <notifications@github.com>

> In tests/unit/core/test_roles.py:
>
> > @@ -100,52 +119,50 @@ def gets_distro_info_for_centos(self):
> >
> >      @istest
> >      def ignores_line_if_already_exists_in_file(self):
> > -        with self.mock_role_method('has_line') as has_line, self.execute_mock() as execute:
> > +        with self.mock_role_methods("has_line", "put_file", "execute") as mocked:
>
> Why is "put_file" being mocked if it doesn't participate on this test? I
> think you should either not mock it, or make it clear how you want it to be
> used. (Perhaps self.assertFalse(put_file.called)?)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/python-provy/provy/pull/116/files#r2990040>.
>
>