Remove spurious ';'

Signed-off-by: Simon Horman <horms@verge.net.au>
Correct whitespace

Remove trailing whitespace
Correct indentation

Signed-off-by: Simon Horman <horms@verge.net.au>
Capture stderr from ip monitor

Capture stderr from ip monitor to allow it to be displayed
if and only if an error is detected.

Signed-off-by: Simon Horman <horms@verge.net.au>
Wait for output from ip monitor

Wait for the expected output rather than assuming it is present.

Also, direct stderr to PIPE so that it can be read if an error occurs.

Signed-off-by: Simon Horman <horms@verge.net.au>
Catch errors when starting process in start_link_monitor

Signed-off-by: Simon Horman <horms@verge.net.au>
Capture stdout and stderr in start_link_monitor()

Capture stdout and stderr in start_link_monitor()
and only display it if an error occurs.

Signed-off-by: Simon Horman <horms@verge.net.au>
Always ip monitor link when setting negotiation parameters

The assumptions are that that ip monitor link reflects events that
have been seen by the ethernet driver which occurs after they are seen by
the phy. And that ethtool which reflects the state of the phy. So
ethtool should be run once ip monitor link indicates link change
events have propogated to the driver. Otherwise ethtool may indicate
the pre-link change state.

Signed-off-by: Simon Horman <horms@verge.net.au>
Do not retry tests

Treat failure as failure every time

Signed-off-by: Simon Horman <horms@verge.net.au>