i think the future i think you might vary the thresholds based on product,
or more like supply point type (warehouse will want a bigger buffer). at
the point when we start adding that stuff, i'm not sure this method can
live in this class anyway, as it will have to refer to other docs and to do
so efficiently you'll have to consolidate the queries at a higher level.


On Thu, Jun 20, 2013 at 6:55 PM, Cory Zue <notifications@github.com> wrote:

> In corehq/apps/commtrack/models.py:
>
> > +
> > +    @property
> > +    def default_consumption(self):
> > +        # TODO does this belong in this class? in the future this will be configurable
> > +        # based on (product, supply point type)
> > +        return DEFAULT_CONSUMPTION
> > +
> > +    @staticmethod
> > +    def default_thresholds():
> > +        return {
> > +            'low': UNDERSTOCK_THRESHOLD,
> > +            'high': OVERSTOCK_THRESHOLD,
> > +        }
> > +
> > +    @property
> > +    def stock_thresholds(self):
>
> in which case - what's the point of the other function?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dimagi/commcare-hq/pull/490/files#r4809699>
> .
>