Could you please elaborate a bit more?

It's one of the first the first times I'm submitting a pull request instead of packaging/releasing a hotfixed gem on my own gem server in prod, so I want to get a hang of this an turn contributing into a habit.

Are there any other attributes I should be checking equality for? Is there anything wrong with this style of coding (am I breaking any guidelines)? Is there something conceptually wrong with this snippet/approach that I'm not seeing?

Thanks in advance for an answer.