Added docstrings, and improved some of the comments on several tasks.
ceph_manager: workaround for 6116

This is an annoying race, we really should delay going
clean until the backfill peer has acknoledged the clean
info, but we currently don't.  In order to prevent this
bug from messing up the nightlies, we'll delay killing
the peer for 20s to make it likely that the backfill
peer has gotten the clean info.

Workaround: #6116
Signed-off-by: Samuel Just <sam.just@inktank.com>
rbd_fsx: do not exceed 250GB for fsx image

This breaks on 32-bit architectures because fsx can't allocate the
in-memory buffer or hit some other limit.  500MG also seems to run out of
memory (tho it at least does not segfault).

Fixes: #6576

Signed-off-by: Sage Weil <sage@inktank.com>
Merge pull request #143 from ceph/wip-6576

fix rbd fsx on 32-bit

Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
Use worker httpd instead of prefork (like ubuntu) on rpm distros.

Ubuntu's default apache uses worker instead of prefork like rpm
based distro's. If rpm use httpd.worker instead of httpd so that
the -X behavior will not be blocked by a single request.

Signed-off-by: Sandon Van Ness <sandon@inktank.com>
Add docstrings to every function. And a few other comments.

Signed-off-by: Zack Cerza <zack.cerza@inktank.com>
Fix param docstring format to be more Sphinx-y

Signed-off-by: Zack Cerza <zack.cerza@inktank.com>
Fix some PEP-8 issues

Signed-off-by: Zack Cerza <zack.cerza@inktank.com>
Merge pull request #145 from ceph/wip-5939

Document install task
Merge pull request #144 from ceph/wip-doc5939-wusui

Added docstrings, and improved some of the comments on several tasks.
Merge branch 'next'
ceph_manager: remove 6116 workaround

Signed-off-by: Samuel Just <sam.just@inktank.com>
install.upgrade: fix overrides of sha1|tag|branch

If the upgrade task config has a branch: (or tag or sha1), do
not apply the sha1|branch|tag overrides keys.  This fixes the
breakage from 280f783c2e8dda0df6afb4de0b115aad1614fbdc which
made

overrides:
  install:
    ceph:
      sha1: f88866fe9c218e03b3f89ff21e2b7b655aa74294
tasks:
...
- install.upgrade:
    all:
      branch: dumpling

...use the sha1 from the overrides instead of the explicitly
specified branch.  The intention was to only use the overrides
when the version was not specified (whether it was sha1 or
branch or tag).

At some point we should probably make the same change for
install function in install.py, but let's fix this first to
get the upgrade tests working.

Signed-off-by: Sage Weil <sage@inktank.com>
Merge pull request #148 from ceph/wip-upgrade

install.upgrade: fix overrides of sha1|tag|branch
Added two new tasks.  tgt starts up the tgt service.  iscsi starts
up the iscsi service and logins to an rbd image using the tgt service
(either locally or remotely).  The iscsi service runs some
simple tests, and then sets up the isci-image to be useable by
rbd test scripts.  Later workunits can perform further testing
on the isci-image interface.

In order to add the new tasks, common_fs_utils.py was formed
from code extracted out of rbd.py.  Rbd.py and iscsi.py both
call the functions in this module.

Fixes: #6433
Signed-off-by: Warren Usui <warren.usui@inktank.com>
Reviewed-by: Josh Durgin
install.upgrade: deepcopy() overrides before we modify it

Since we modify the dict, make sure it is a deep copy.
Otherwise, a sequence like:

- install.upgrade:
    all:
      branch: dumpling
...
- install.upgrade:
    all: null

will delete the overrides keys in the first upgrade call and
then not have them at all in the second.

Signed-off-by: Sage Weil <sage@inktank.com>