I took away the TODO.  Given our priorities at the moment, I think this might be area I'd like to revisit soon, but not now.
Maybe on the backlog? Refactoring story? Does that sound reasonable?

On Dec 17, 2013, at 12:34 PM, Tom McKay <notifications@github.com> wrote:

> In app/controllers/katello/api/v2/products_controller.rb:
> 
> >    param_group :search, Api::V2::ApiController
> >    def index
> > -    options = sort_params
> > -    options[:load_records?] = true
> > -
> > -    ids = Product.all_readable(@organization).pluck(:id)
> > -
> > -    options[:filters] = [
> > -      {:terms => {:id => ids}}
> > -    ]
> > -    options[:filters] << {:term => {:enabled => params[:enabled]}} if params.key?(:enabled)
> > -
> > +    # TODO: extract the filtering into methods
> I'm fine w/ either leaving this w/o the TODO, or fixing the TODO now. What did you decide?
> 
> —
> Reply to this email directly or view it on GitHub.
>