Fix ASSERTMSG definition and usage (which is: ASSERTMSG(Message, expression) and not the other way around, see http://msdn.microsoft.com/en-us/library/windows/hardware/ff542113(v=vs.85).aspx , http://www.osronline.com/DDKx/ddtools/debugfns_41yr.htm and google...) (Part 1/X)

git-svn-id: svn://svn.reactos.org/reactos/trunk@59508 97493ccd-5924-5043-b1f5-66cb403b36ce
Fix ASSERTMSG definition and usage (which is: ASSERTMSG(Message, expression) and not the other way around, see http://msdn.microsoft.com/en-us/library/windows/hardware/ff542113(v=vs.85).aspx , http://www.osronline.com/DDKx/ddtools/debugfns_41yr.htm and google...) (Part 2/X)
WARNING: Might break builds now.

git-svn-id: svn://svn.reactos.org/reactos/trunk@59509 97493ccd-5924-5043-b1f5-66cb403b36ce
Fix ASSERTMSG definition and usage (which is: ASSERTMSG(Message, expression) and not the other way around, see http://msdn.microsoft.com/en-us/library/windows/hardware/ff542113(v=vs.85).aspx , http://www.osronline.com/DDKx/ddtools/debugfns_41yr.htm and google...) (Part 3/4)
NOTE: Fixing builds ;)

git-svn-id: svn://svn.reactos.org/reactos/trunk@59510 97493ccd-5924-5043-b1f5-66cb403b36ce
Fix ASSERTMSG definition and usage (which is: ASSERTMSG(Message, expression) and not the other way around, see http://msdn.microsoft.com/en-us/library/windows/hardware/ff542113(v=vs.85).aspx , http://www.osronline.com/DDKx/ddtools/debugfns_41yr.htm and google...) (Part 4/4)
Everything fixed now \o/

git-svn-id: svn://svn.reactos.org/reactos/trunk@59511 97493ccd-5924-5043-b1f5-66cb403b36ce
Add the SYNCHRONIZE flag to the DesiredAccess parameter when using the flags FILE_SYNCHRONOUS_IO_(NON)ALERT in NtCreateFile or NtOpenFile, even if one uses DesiredAccess == GENERIC_xxx (which should map to some FILE_GENERIC_xxx already containing the SYNCHRONIZE flag).
Indeed, it appears after extended testing that, when calling from user-mode, Windows checks the real presence of the SYNCHRONIZE flag when using FILE_SYNCHRONOUS_IO_(NON)ALERT even if we pass any of the GENERIC_xxx access flags...

Part 1/X

git-svn-id: svn://svn.reactos.org/reactos/trunk@59512 97493ccd-5924-5043-b1f5-66cb403b36ce
[WIDL]
- Apply Wine commit "widl: Avoid short printf formats with int variables." (7ca08fee) by Alexandre Julliard. Fixes clang warnings

git-svn-id: svn://svn.reactos.org/reactos/trunk@59513 97493ccd-5924-5043-b1f5-66cb403b36ce
Add the SYNCHRONIZE flag to the DesiredAccess parameter when using the flags FILE_SYNCHRONOUS_IO_(NON)ALERT in NtCreateFile or NtOpenFile, even if one uses DesiredAccess == GENERIC_xxx (which should map to some FILE_GENERIC_xxx already containing the SYNCHRONIZE flag).
Indeed, it appears after extended testing that, when calling from user-mode, Windows checks the real presence of the SYNCHRONIZE flag when using FILE_SYNCHRONOUS_IO_(NON)ALERT even if we pass any of the GENERIC_xxx access flags...

Otherwise, when using FILE_GENERIC_(READ/WRITE) flags directly, there is no need to add the SYNCHRONIZE flag since it is already incorporated in it.

See CORE-7361 for more details.

git-svn-id: svn://svn.reactos.org/reactos/trunk@59514 97493ccd-5924-5043-b1f5-66cb403b36ce
Final fixes for the SYNCHRONIZE flag
CORE-7361 #resolve #comment Fixed in revisions 59512, 59514 and 59515.

git-svn-id: svn://svn.reactos.org/reactos/trunk@59515 97493ccd-5924-5043-b1f5-66cb403b36ce
[WIN32K]: Get rid of unused variables, fix all warnings on GCC 4.7

git-svn-id: svn://svn.reactos.org/reactos/trunk@59516 97493ccd-5924-5043-b1f5-66cb403b36ce
[RTL]
- Fix a potential overflow bug.
- Don't hardcode the "/ 2" in indices computation (2 == sizeof(WCHAR))
- Fix a string enumeration bug when enumerating strings inside REG_MULTI_SZ values, in RtlQueryRegistryValues.

git-svn-id: svn://svn.reactos.org/reactos/trunk@59517 97493ccd-5924-5043-b1f5-66cb403b36ce
[SMSS]
- In the token parsing function SmpParseToken, just return success directly if the input string has zero length, instead of running code which does nothing at the end, because the length was zero...
- Give a default value for the "BootExecute" entry in the SMSS registry configuration table (this value is used when there is no BootExecute registry value inside HKLM\System\CurrentControlSet\Control\Session Manager) and precise that it is a multi-string value.
- Remove a redundant "Environment" entry in this table, too.

git-svn-id: svn://svn.reactos.org/reactos/trunk@59518 97493ccd-5924-5043-b1f5-66cb403b36ce
[ADNS]
* Silence some warnings.

git-svn-id: svn://svn.reactos.org/reactos/trunk@59519 97493ccd-5924-5043-b1f5-66cb403b36ce
[CARDLIB]
* Silence some warnings.

git-svn-id: svn://svn.reactos.org/reactos/trunk@59520 97493ccd-5924-5043-b1f5-66cb403b36ce
[LIBXML2]
* Disable warnings.

git-svn-id: svn://svn.reactos.org/reactos/trunk@59521 97493ccd-5924-5043-b1f5-66cb403b36ce
[UNIATA]
* Silence some warnings.

git-svn-id: svn://svn.reactos.org/reactos/trunk@59522 97493ccd-5924-5043-b1f5-66cb403b36ce
[GLU32]
* Silence some warnings.

git-svn-id: svn://svn.reactos.org/reactos/trunk@59523 97493ccd-5924-5043-b1f5-66cb403b36ce
[WINMM_WINETEST]
* Silence some warnings.

git-svn-id: svn://svn.reactos.org/reactos/trunk@59524 97493ccd-5924-5043-b1f5-66cb403b36ce
[FBTUSB]
* Silence some warnings.

git-svn-id: svn://svn.reactos.org/reactos/trunk@59525 97493ccd-5924-5043-b1f5-66cb403b36ce
[USBCCGP]: FDO_HandleResetCyclePort should complete the pending IRPs, not the reset IRP. In fact, since the caller (FDO_HandleInternalDeviceControl) already completes the reset IRP, this was also causing double IRP completion. THIS IS WHY GCC 4.7 WARNINGS ARE IMPORTANT.

git-svn-id: svn://svn.reactos.org/reactos/trunk@59526 97493ccd-5924-5043-b1f5-66cb403b36ce
[MISC]: Cleanup a bunch of unused variables, in cases where it was obvious these variables were left-overs from debug code, debug prints, or in some cases commented-out functionality (in which case the variables were commented out instead of removed). If you own ACLUI, CLASS2, USB, USER32, or EXT2LIB you may want to check that these changes are accurate (i.e.: such as the last commit where the variable was actually not being used due to a bug).

git-svn-id: svn://svn.reactos.org/reactos/trunk@59527 97493ccd-5924-5043-b1f5-66cb403b36ce