need to assign keys and values