I think at that point it would mean that the API isn't following it's part
of the deal.

As long as the node is there I don't think we should worry about it. Until
the carrier proves us wrong ;)


On 17 December 2013 15:00, Neil Costford <notifications@github.com> wrote:

> In lib/active_shipping/shipping/carriers/fedex.rb:
>
> > @@ -537,6 +555,12 @@ def extract_destination(document)
> >          Location.new(args)
> >        end
> >
> > +      def extract_timestamp(document, node_name)
> > +        if timestamp_node = document.elements[node_name]
> > +          Time.parse(timestamp_node.to_s).utc
>
> Is it too defensive to worry that the timestamp node is not a
> valid/parseable string?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Shopify/active_shipping/pull/127/files#r8415164>
> .
>



-- 
Chris Saunders // Developer @ Shopify