started working on function params