Just seems like it should return a boolean. I don't suppose there is a
problem with truthy / falsy vs boolean but don't see a point in changing
something that is cleaner to be less clean. `isWhatever` or
`shouldWhatever` should always return boolean IMHO.


On Thu, Jan 3, 2013 at 10:45 AM, Kevin Decker <notifications@github.com>wrote:

> In src/collection.js:
>
> > @@ -19,6 +19,9 @@ Thorax.Collection = Backbone.Collection.extend({
> >    isPopulated: function() {
> >      return this._fetched || this.length > 0 || (!this.length && !_.result(this, 'url'));
> >    },
> > +  shouldFetch: function(options) {
> > +    return options.fetch && !!_.result(this, 'url') && !this.isPopulated();
>
> !this.isPopulated is going to make the result boolean if all truthy and
> worst case you get a falsy value if result is falsy. What is the issue
> thruthy and falsy?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/walmartlabs/thorax/pull/90/files#r2541970>.
>
>