Sync - refactor should_upload to return a constants  instead of strings
Sync - tests - should_upload - additional tests for constants