Yes. /facepalm


On Wed, Nov 6, 2013 at 7:13 PM, Spiros Eliopoulos
<notifications@github.com>wrote:

> In lib/Controller.ml:
>
> > @@ -21,16 +21,51 @@ let switch_thread
> >    lwt () = config_switch (Stream.now local_stream) in
> >    Lwt_stream.iter_s config_switch (Stream.to_stream local_stream)
> >
> > +(* We analyze the topology (currently from 't'), and compute the edge
> > +   switches. For edge locations L_e, the policy is (filter L_e;i | filter ~L_e); (p | e). But, it is probably better to instead use the internal locations L_i, making it (filter ~L_i;i | filter L_i); (p | e)
> > +*)
> > +
> > +let rec extract_internal_locs t =
> > +  let open Types in
> > +      match t with
> > +        | Seq(p,q) -> Or (extract_internal_locs p, extract_internal_locs q)
> > +        | Par(p,q) -> Or (extract_internal_locs p, extract_internal_locs q)
> > +        | Choice(p,q) -> Or (extract_internal_locs p, extract_internal_locs q)
> > +        | Link(sw,pt,sw',pt') -> Or (And (Test (Switch, sw), Test (Switch, pt)),
> > +                                     And (Test (Switch, sw'), Test (Switch, pt')))
>
> Should the test for the port be on the InPort header instead of Switch?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/frenetic-lang/frenetic/pull/128/files#r7483385>
> .
>