Ok, I think we're on the same page then.


On Fri, Oct 25, 2013 at 1:29 PM, Jason Draper <notifications@github.com>wrote:

> In
> lib/shoulda/matchers/active_record/association_matchers/model_reflection.rb:
>
> > +              end
> > +
> > +            join_table.to_s
> > +          end
> > +
> > +          def association_relation
> > +            if reflection.respond_to?(:scope)
> > +              convert_scope_to_relation(reflection.scope)
> > +            else
> > +              convert_options_to_relation(reflection.options)
> > +            end
> > +          end
> > +
> > +          private
> > +
> > +          attr_accessor :reflection, :subject
>
> My general opinion is to use the instance variables in the construction
> and then user the attr_reader elsewhere.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/thoughtbot/shoulda-matchers/pull/373/files#r7222466>
> .
>