handle amending the same in magit-{commit & tag}
magit-with-git-editor-setup: improve macro hygiene
use emacsclient from same directory as emacs process
kludge for process-attributes returning nil
`magit-process-yes-or-no-prompt-regexp': robustify regexp

It only needs to match ssh(1)'s "Are you sure you want to continue
connecting (yes/no)?" prompt for the time being, but it doesn't hurt
to make it a bit more receptive:  Make it also match an optional space
after the closing square bracket or paren, and maybe a colon instead
of a question mark at the end.

Signed-off-by: Pieter Praet <pieter@praet.org>
`magit-refresh-commit-buffer': pass `magit-diff-options' to git-log(1)

Take custom diff options into account when using `magit-show-commit'.

See commit a233bd4d.

Signed-off-by: Pieter Praet <pieter@praet.org>
Merge pull request #774 from praet/process-prompts-leftovers

`magit-process-yes-or-no-prompt-regexp': robustify regexp
`magit-key-mode-groups': 'committing': fix parens

Commit b0954e50 moved the "--gpg-sign" flag from 'arguments'
to 'switches', but didn't properly adjust the parentheses.

Signed-off-by: Pieter Praet <pieter@praet.org>
Merge pull request #776 from praet/paren-fix

`magit-key-mode-groups': 'committing': fix parens
Merge pull request #775 from praet/show-commit-diff-opts

`magit-refresh-commit-buffer': pass `magit-diff-options' to git-log(1)
`magit-tag': s/"-a"/"--annotate"/g

Enabling the "-a" switch in `magit-key-mode-popup-tagging' adds
"--annotate" to `magit-custom-options', however `magit-tag'
checked for the presence of "-a" to decide whether or not to use
`magit-with-git-editor-setup' + `magit-run-git-async'.

As a result, creating an annotated tag by setting the "-a" flag in
the tagging popup opened a new frame instead of using the existing
one, and blocked the parent Emacs process.

Signed-off-by: Pieter Praet <pieter@praet.org>
`magit-tag': s/amendp/annotate/g

git-tag(1)'s "-a" != git-commit(1)'s "-a"

Signed-off-by: Pieter Praet <pieter@praet.org>
Merge pull request #778 from praet/annotated-tag-fixes

Annotated tag fixes