I believe that next_grader_type was still "PE" in my DB for finished and posted-back responses, but your change is safer.


On Sep 20, 2013, at 11:31 AM, Vik Paruchuri <notifications@github.com> wrote:

> In peer_grading/peer_grading_util.py:
> 
> > @@ -46,6 +46,18 @@ def graded_count(self):
> >          """
> >          return self.graded().count()
> >  
> > +    def submissions_completed_peer_grading(self):
> > +        """
> > +        Gets all non-duplicate submissions that have "completed" the peer evaluation process.
> > +        @return:
> > +        """
> > +        return self.location_submissions().exclude(student_id=self.student_id).filter(
> > +            state=SubmissionState.finished,
> > +            posted_results_back_to_queue=True,
> > +            is_duplicate=False,
> > +            next_grader_type="PE",
> Have you tested this? I think you want to filter on preferred_grader_type. Next_grader_type might be NA after a submission has been finished and posted back, but preferred_grader_type will always be PE.
> 
> —
> Reply to this email directly or view it on GitHub.
>