Sure, could; I find it less readable since you have to fall thru to the
rest of the (relatively large and nested) method in order to find out
absolutely nothing else happens though.

It may just be personal preference, but I'd rather see what happens as
quickly as possible ("fail fast" kind of thing).


On Mon, Jan 7, 2013 at 5:24 PM, Wesley Beary <notifications@github.com>wrote:

> In lib/excon/socket.rb:
>
> > @@ -80,9 +83,7 @@ def connect
> >
> >      def read(max_length=nil)
> >        return nil if @eof
>
> Could we actually kill the return here and have it read like:
>
> if @eof
>   nil
> elsif @params[:nonblock]
>
> I think that accomplishes the same thing, but is a bit more consistent in
> terms of style with other parts of the code base.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/geemus/excon/pull/178/files#r2570714>.
>
>



-- 
e: davelnewton@gmail.com
m: 908-380-8699
s: davelnewton_skype
t: @dave_newton <https://twitter.com/dave_newton>
b: Bucky Bits <http://buckybits.blogspot.com/>
g: davelnewton <https://github.com/davelnewton>
so: Dave Newton <http://stackoverflow.com/users/438992/dave-newton>