I agree.  That’s a reasonable concern.

Can we compromise and allow them now to get BDD passing again and then look at the cause when we are together?

I suspect there’s something simple that’s breaking and we just need to look at the code together to figure out what.

From: Victor Lowther [mailto:notifications@github.com]
Sent: Tuesday, November 19, 2013 6:44 AM
To: crowbar/barclamp-crowbar
Cc: Hirschfeld, Rob
Subject: Re: [barclamp-crowbar] BDD Test Coverage Improvement (just 1 left!) [1/3] (#771)


In crowbar_framework/app/models/run.rb:

> @@ -40,7 +40,7 @@ def self.cleanup

>      Run.transaction do

>        ActiveRecord::Base.connection.execute("LOCK TABLE runs")

>        deletable.each do |j|

> -        Rails.logger.info("Run: Deleting #{j.node_role.name}: state #{j.node_role.state}")

> +        Rails.logger.info("Run: Deleting #{j.node_role.name}: state #{j.node_role.state}") unless j.node_role.nil?

I really don't like the nil checks here -- the fact that you see the need for them in test/development mode means that they diverge too far from how the system operates in production mode.

—
Reply to this email directly or view it on GitHub<https://github.com/crowbar/barclamp-crowbar/pull/771/files#r7758615>.