ah, yes. I wrote it before you made the change from per to indexed by id.


On Fri, Sep 6, 2013 at 9:07 AM, Calen Pennington
<notifications@github.com>wrote:

> In common/lib/xmodule/xmodule/modulestore/inheritance.py:
>
> > -            pass
> > -
> > -    return metadata
> > +    return module.get_explicitly_set_fields_by_scope(Scope.settings)
> > +
> > +class InheritanceKeyValueStore(KeyValueStore):
> > +    """
> > +    Common superclass for kvs's which know about inheritance of settings. Offers simple
> > +    dict-based storage of fields and lookup of inherited values.
> > +
> > +    Note: inherited_settings is a dict of key to json values (internal xblock field repr)
> > +    """
> > +    def __init__(self, initial_values=None, inherited_settings=None):
> > +        super(InheritanceKeyValueStore, self).__init__()
> > +        self.inherited_settings = inherited_settings or {}
> > +        self._fields = initial_values or {}
>
> Probably not to change for this PR, but: this looks like it's only
> expecting to work for per-xblock-instance KVS's. What happens when we want
> to make modulestore into a FieldData?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/edx/edx-platform/pull/844/files#r6207203>
> .
>