+1
OK, sounds fair to me.
if ( okDbyJenkinks() ) approve()    #  :)



On Mon, Sep 30, 2013 at 10:17 AM, Giulio Eulisse
<notifications@github.com>wrote:

>  In RecoBTag/XMLCalibration/interface/CalibrationXML.h:
>
> > @@ -36,8 +37,8 @@ class CalibrationXML
> >
> >          void closeFile()
> >          {
> > -          if(errHandler) delete errHandler;
> > -          if(parser) {  delete parser; XMLPlatformUtils::Terminate(); }
> > +          delete errHandler;
> > +          delete parser; cms::concurrency::xercesTerminate();
>
> I see what you mean. I think the if() is there simply because the original
> author did not know that "delete 0" is actually a valid statement (and a
> no-op). As far as I can tell from the documentation of
> XMLPlatformUtils::Initialize() and XMLPlatformUtils::Terminate() they are
> reference counted. I could cleanup also the other ifs (maybe in a different
> PR). The reason why this was cleaned up and not the others is that it was
> done by hand while the others with a perl regexp.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cms-sw/cmssw/pull/943/files#r6651845>
> .
>



-- 
Thanks,
       cheers, andreas