net: remove dreg of obsoleted network poller

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/13396051
runtime: clean up / align comment tabbing

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/13336046
libmach: change three more BGET macro invocations back

Various compilers complain about the macro expansion not
being used. I fixed a few yesterday. More today.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13643044
go/build: allow $ in cgo LDFLAGS

Fixes issue 6038.

R=iant
CC=golang-dev
https://codereview.appspot.com/13649043
cmd/go: implement -x correctly for 'go vet', 'go fmt', and so on

Fixes issue 5676.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13250047
cmd/go: fix build -n output when using swig

$INTBITS will not be defined, of course, but that's the best we can do.

Fixes issue 5978.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/13253048
CONTRIBUTORS: add Alexis Imperial-Legrand (Google CLA)

R=golang-dev, bradfitz
CC=ail, golang-dev
https://codereview.appspot.com/13441050
runtime: explicit init of runtime-gdb helpers

If using other gdb python scripts loaded before Go's gdb-runtime.py
and that have a different init prototype:
Traceback (most recent call last):
  File "/usr/lib/go/src/pkg/runtime/runtime-gdb.py", line 446, in <module>
    k()
TypeError: __init__() takes exactly 3 arguments (1 given)

The problem is that gdb keeps all python scripts in the same namespace,
so vars() contains them. To avoid that, load helpers one by one.

R=iant, rsc
CC=gobot, golang-dev
https://codereview.appspot.com/9752044

Committer: Russ Cox <rsc@golang.org>
cmd/go: better error for shadowed directories in GOPATH

Fixes issue 5774.

R=golang-dev, adg, r, bradfitz
CC=golang-dev
https://codereview.appspot.com/9164043
cmd/go: build SWIG shared libraries in work directory

Remove test of whether SWIG shared library is older than
sources--should be covered by test of package file anyhow.

Fixes issue 5739.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/13352046
cmd/go: report real package in errors for go get with wildcard

Fixes issue 5054.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/13609043
cmd/go: fix error for 'go install x.go' when GOBIN is not set

Fixes issue 6191.
Fixes issue 5426.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13234052
go/doc: restore handling of multi-paragraph BUG comments

It was lost when the generic "Notes" support went in.

Had to change the test setup, because it precluded even
being able test multi-line comments, much less multi-paragraph
comments.

Now 'godoc sync/atomic' works correctly again.

Fixes issue 6135.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13427045
cmd/go: run benchmarks in sequence

Fixes issue 5662.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13650043
cmd/go: fix go test using package main_test

A package main binary (that is, a command) being installed
does not mean we can skip the build of the package archive
during a test.

Fixes issue 3417.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13462046
cmd/go: show FAIL for errors during test setup

For example, if an x_test.go file contains a syntax error,
b.test fails with an error message. But it wasn't printing
the same FAIL line that a build failure later would print.
This makes all the test failures that happen (once we
decide to start running tests) consistently say FAIL.

Fixes issue 4701.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13431044
A+C: Arnaud Ysmal (individual CLA)

Generated by addca.

R=gobot
CC=golang-dev
https://codereview.appspot.com/13265044
libmach: accept OS X binary generated by external linker

Fixes cpu subtype check when using external linker which sets the CPU_SUBTYPE_LIB64 bit (1<<31).
Fixes issue 6197.

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://codereview.appspot.com/13248046

Committer: Brad Fitzpatrick <bradfitz@golang.org>
cmd/6l, cmd/8l: fix MOVL MOVQ optab

The entry for LEAL/LEAQ in these optabs was listed as having
two data bytes in the y array. In fact they had and expect no data
bytes. However, the general loop expects to be able to look at at
least one data byte, to make sure it is not 0x0f. So give them each
a single data byte set to 0 (not 0x0f).

Since the MOV instructions have the largest optab cases, this
requires growing the size of the data array.

Clang found this bug because the general o->op[z] == 0x0f
test was using z == 22, which was out of bounds.

In practice the next byte in memory was probably not 0x0f
so it wasn't truly broken. But might as well be clean.

Update issue 5764

R=ken2
CC=golang-dev
https://codereview.appspot.com/13241050
build: more "undefined behavior" fixes

Fixes issue 5764.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13441051