I'm happy to remove that one. I put the comment there particularly to see
if anyone thought it was necessary to keep.


On Fri, Jul 26, 2013 at 8:51 AM, Don-edX Mitchell <dmitchell@edx.org> wrote:

> Only an abundance of caution. The problem is that __init__ on some of our
> descriptors set fields. I think I ensured that get_item will call .save()
> but preview had an odd pattern which I vacillated on.
>
>
> On Thu, Jul 25, 2013 at 9:57 PM, chrisndodge <notifications@github.com>wrote:
>
>> In cms/djangoapps/contentstore/views/preview.py:
>>
>> > @@ -43,6 +43,8 @@ def preview_dispatch(request, preview_id, location, dispatch=None):
>> >      """
>> >
>> >      descriptor = modulestore().get_item(location)
>> > +    # decache any pending field settings -- this one may be overkill
>> > +    descriptor.save()
>>
>> IMO, does seem like overkill. Can you explain why you think you might
>> need this?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/edx/edx-platform/pull/505/files#r5414625>
>> .
>>
>
>