started work on attribute model