It is called with it as a string, only that for the tests it has to be
called this way.

Sent from my iPhone

On Jul 8, 2013, at 5:07 AM, Lane LaRue <notifications@github.com> wrote:

In spec/dynamoid/criteria/chain_spec.rb:

> @@ -50,7 +50,8 @@
>      @chain.query = {:name => 'Josh', :email => 'josh@joshsymonds.com'}
>      @chain.send(:index_query).should == {:hash_value => 'josh@joshsymonds.com.Josh'}
>
> -    @chain.query = {:name => 'Josh', 'created_at.gt' => @time}
> +    # All keys are converted to_sym in the where method, so we should pass them in query as Symbols.
> +    @chain.query = {:name => 'Josh', 'created_at.gt'.to_sym => @time}

While passing 'name' as symbol instead of a string seems natural, "
created_at.gt" seems like an extra burden on the caller. I would expect
most people would just call it with "created_at.gt" in string form, which
is probably what the test should express.

—
Reply to this email directly or view it on
GitHub<https://github.com/Veraticus/Dynamoid/pull/128/files#r5056456>
.