I decided (details in yesterday's IM history) that allow it through did not make sense. Because remove and add manipulate the order (reorder) beyond then point if removal , the net result would likely be duplicate entries if the entries had been ooo before the add/remove. It *should* fire an exception in loadsubfiles but I am worried that would cause too much pain in Prod if there are too many existing corrupt supers there now

On 24 Oct 2013, at 08:44, "Richard Chapman" <notifications@github.com<mailto:notifications@github.com>> wrote:


In dali/base/dadfs.cpp:

>                      WARNLOG("addSubFile: File %s is not a subfile of %s", subfile.get(),parent->queryLogicalName());
> +                }
> +                else
> +                {
> +                    VStringBuffer path("SubFile[@name=\"%s\"]", subfile.get());
> +                    IPropertyTree *sub = sf->root->queryPropTree(path.str());
> +                    dbgassertex(sub);
> +                    if ((pos+1) != sub->getPropInt("@num"))
> +                        ThrowStringException(-1, "RemoveSubFile: SuperFile %s, subfile %s, part numbers are out of sequence. SubFile[@num=\"%d\"] is at position %d", sf->logicalName.get(), subfile.get(), sub->getPropInt("@num"), pos+1);


I thought the intention was to handle this case without failing (but warn) ?

—
Reply to this email directly or view it on GitHub<https://github.com/hpcc-systems/HPCC-Platform/pull/5053/files#r7181280>.