Source formatting
SOS-1221 Implementing and moving SODeployListenerMessageListener to so-hook
SOS-1221 Format-source
SOS-1221 Reran ant "setup-eclipse" in so-hook and so-portlet because the the "import.shared" in build.xml got moved from one plugin to the other
SOS-1221 Undo unnecessary change from tabs to 4 spaces, be careful with these!
SOS-1221 Proper fix for changing logging level, otherwise, we will still be printing out the messages. The way logging levels work. See logging hierarchy in http://logging.apache.org/log4j/1.2/manual.html. When you say that in the properties that you want to print DEBUG, then it will print DEBUG and everything lower than it. And INFO is lower than DEBUG, so it'll still print the messages. By switching the property to INFO, we will only print stuff lower than it, and DEBUG is higher than INFO, so no messages will get printed. The order is TRACE, DEBUG, INFO, WARN, ERROR, FATAL.
SOS-1221 Catch only the exception, and add a message. I think this is what you wanted, can you double check the comment? Is that a true statement?
SOS-1221 I never (or rarely) use import .* in Java. I think it's a bad practice. In this case, if we import so.util.RoleConstants and not the portal one, we can use the RoleConstants.SOCIAL_OFFICE_USER
SOS-1221 I usually use String.valueOf instead of Boolean.valueOf cause it's smarter.
SOS-1221 1.) method names should start with a verb, so it is "cleanUpSocialOffice" vs "socialOfficeCleanup". Methods take an action and do something. 2.) See updateGroups, I used the pattern of "for (int i = 0; i <= pages; i++) {", just search for Indexer.DEFAULT_INTERVAL in portal master. It prevents us loading EVERY community into memory. Imagine if there are 1 million. This allows us to paginate. 3.) I don't see the point of "updateUsers". When you delete the Social Office User role, the logic to trigger the RoleListener should already happen in "deleteSocialOfficeUserRole". But if you did need that logic, also use the pattern of "for (int i = 0; i <= pages; i++) {" or you will get slammed loading 1 million users from the db.
SOS-1248 Nothing happens after clicking on an announcement in the notifications portlet
SOS-1248 Source formatting
SOS-1010 User cannot leave a Private Site
SOS-1247 Forums breadcrumb shows the portlet label
LPS-30598 Manual changes
LPS-30598 Regenerate
Source formatting
LPS-30170 Regenerate
LPS-30559 Minor changes to allow for easier testing
LPS-30559 1.) Follow pattern in test-pacl/*/liferay-plugin-package.properties for variable replacement 2.) only set the payload if there is a response