improveMuonBestTrack() is not part at all of the reco::Muon, and it is 
the requested hack to have the new tuneP algorithm available in PAT, so 
it needs to be stored. muonBestTrack() is also restored, fixing the bug 
that was left errant. Off course I need to do that, also to keep the 
symmetry w/ improvedMuonBestTrack (that one is implemented correctly 
from the beginning, I did not want to implement it wrongly to have the 
same wrong behavior of muonBestTrack nor having it responding 
differently w.r.t. muonBestTrack).


On 09/03/2013 02:59 PM, Volker Adler wrote:
>
> In DataFormats/PatCandidates/interface/Muon.h:
>
> > @@ -83,9 +80,20 @@
> >        reco::TrackRef combinedMuon() const;
> >        /// reference to Track reconstructed in both tracked and muon detector (reimplemented from reco::Muon)
> >        reco::TrackRef globalTrack() const { return combinedMuon(); }
> > +      /// reference to the Best Track reconstructed in both tracked and muon detector (reimplemented from reco::Muon), old (default bt deprecated) tuneP
> > +      reco::TrackRef muonBestTrack();
> > +      /// reference to the Best Track reconstructed in both tracked and muon detector (reimplemented from reco::Muon), after new tuneP
> > +      reco::TrackRef improvedMuonBestTrack();
>
> Indeed, the functions /do/ change the data by embedding the 
> corresponding tracks, if not yet done. That looks odd to me me, too 
> (did not realise it earlier). @bellan <https://github.com/bellan> 
> could you please also comment on this?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/cms-sw/cmssw/pull/684/files#r6124528>.
>