not at all.  if you can make it simpler, i'm all for it.

we have a project that needed the updated matcher to be more rigorous about
:presence on a serialized array.
i thought you guys might want to get the fix we made.

feel free to take it, update it and merge it in.

thanks
jon


On Mon, Dec 9, 2013 at 11:34 PM, Elliot Winkler <notifications@github.com>wrote:

> In spec/shoulda/matchers/active_model/validate_presence_of_matcher_spec.rb:
>
> > @@ -87,6 +87,37 @@
> >      end
> >    end
> >
> > +  context 'a required serialized field' do
> > +    before do
> > +      @model = define_model :serial, :things => :string do
> > +        serialize :things
> > +        validates_presence_of :things
> > +      end.new
> > +      create_table 'serials' do |t|
>
> In other words, I don't think you need this here, mind taking it out?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/thoughtbot/shoulda-matchers/pull/398/files#r8224205>
> .
>



-- 
Visit http://bunnymatic.com