Why are you adding more global variables in JS? We have an object for that
in 2.05, add them to the EM object instead.


On Mon, Oct 14, 2013 at 4:40 PM, Denis Chenu <notifications@github.com>wrote:

> In application/helpers/expressions/em_manager_helper.php:
>
> > -                            case 'N': //NUMERICAL QUESTION TYPE
> > -                            case 'K': //MULTIPLE NUMERICAL QUESTION
> > -                                if (trim($value)=="") {
> > -                                    $value = "";
> > -                                }
> > -                                else {
> > -                                    $value = sanitize_float($value);
> > -                                }
> > +#                            case 'N': //NUMERICAL QUESTION TYPE
> > +#                            case 'K': //MULTIPLE NUMERICAL QUESTION
> > +#                                if (trim($value)=="") {
> > +#                                    $value = "";
> > +#                                }
> > +#                                else {
> > +#                                    $value = sanitize_float($value);
> > +#                                }
>
> Sanitization by validate, not by filter
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/LimeSurvey/LimeSurvey/pull/146/files#r6944936>
> .
>