should write a test for proper query string creation