Ah yep, my mistake - `is_float` and `is_double` are the same

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/


On 12 November 2013 00:39, Steve Müller <notifications@github.com> wrote:

> In lib/Doctrine/DBAL/Driver/SQLAnywhere/SQLAnywhereConnection.php:
>
> > +     */
> > +    public function query()
> > +    {
> > +        $args = func_get_args();
> > +        $stmt = $this->prepare($args[0]);
> > +        $stmt->execute();
> > +
> > +        return $stmt;
> > +    }
> > +
> > +    /**
> > +     * {@inheritdoc}
> > +     */
> > +    public function quote($input, $type = \PDO::PARAM_STR)
> > +    {
> > +        if (is_int($input) || is_float($input)) {
>
> I thought doubles and floats are the same in PHP? Am I missing something?
> Besides that this if checks could be left out I think as it quotes all kind
> of strings with the driver function.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/doctrine/dbal/pull/293/files#r7577998>
> .
>