+1 to no coupling
On Jul 30, 2013, at 8:04 AM, Kris Borchers <notifications@github.com> wrote:

> In src/unified-push/aerogear.unifiedpush.js:
> 
> >       */
> > -    AeroGear.UnifiedPushClient = function( variantID, variantSecret, pushServerURL ) {
> > +    AeroGear.UnifiedPushClient = function( variantID, variantSecret, pushServerBaseURL ) {
> > +        // we require the baseURL to be present
> > +        if (! pushServerBaseURL) {
> > +            throw "UnifiedPushClientException";
> > +        }
> > +        var pushServerURL = pushServerBaseURL + "/rest/registry/device";
> Not sure I like this. Since this is the only endpoint ever used in this file, it makes more sense to me to just pass the full URL. That way, if the server ever changes, no update to the client is needed. Even if this client is meant to be used with our server, I'm just not a big fan of hard coding that endpoint as it creates coupling between the client and server.
> 
> —
> Reply to this email directly or view it on GitHub.
>