no not really. originally had a class method only and then realized i
needed to factor out the underlying operation.


On Thu, Jun 20, 2013 at 6:55 PM, Cory Zue <notifications@github.com> wrote:

> In corehq/apps/commtrack/models.py:
>
> > +
> > +    @staticmethod
> > +    def default_thresholds():
> > +        return {
> > +            'low': UNDERSTOCK_THRESHOLD,
> > +            'high': OVERSTOCK_THRESHOLD,
> > +        }
> > +
> > +    @property
> > +    def stock_thresholds(self):
> > +        # TODO does this belong in this class? in the future will these thresholds vary
> > +        # by supply point type? by product?
> > +        return SupplyPointProductCase.default_thresholds()
> > +
> > +    @staticmethod
> > +    def months_of_stock_remaining(stock, consumption):
>
> (not blocking) but any reason this is attached to a class?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dimagi/commcare-hq/pull/490/files#r4809705>
> .
>